fix(site): fix orphan values on insights (#10036)

BrunoQuaresma · web-flow · commit 5e0cb372b439 · 2023-10-04T10:16:59.000-03:00
diff --git a/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.stories.tsx b/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.stories.tsx
@@ -162,6 +162,11 @@ export const Loaded: Story = {
                 value: "us-west2-a",
                 count: 1,
               },
+              // Test orphan values
+              {
+                value: "us-west-orphan",
+                count: 1,
+              },
             ],
           },
           {
diff --git a/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx b/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx
@@ -436,6 +436,7 @@ const TemplateParametersUsagePanel = ({
                   </ParameterUsageRow>
                   {parameter.values
                     .sort((a, b) => b.count - a.count)
+                    .filter((usage) => filterOrphanValues(usage, parameter))
                     .map((usage, usageIndex) => (
                       <ParameterUsageRow
                         key={`${parameterIndex}-${usageIndex}`}
@@ -456,6 +457,16 @@ const TemplateParametersUsagePanel = ({
   );
 };
 
+const filterOrphanValues = (
+  usage: TemplateParameterValue,
+  parameter: TemplateParameterUsage,
+) => {
+  if (parameter.options) {
+    return parameter.options.some((o) => o.value === usage.value);
+  }
+  return true;
+};
+
 const ParameterUsageRow = styled(Box)(({ theme }) => ({
   display: "flex",
   alignItems: "baseline",
