feedback

aslilac · aslilac · commit 5f0883549517 · 2024-08-14T20:25:28.000Z
diff --git a/site/src/components/Filter/filter.tsx b/site/src/components/Filter/filter.tsx
@@ -137,7 +137,7 @@ type FilterProps = {
   filter: ReturnType<typeof useFilter>;
   skeleton: ReactNode;
   isLoading: boolean;
-  learnMoreLink: string;
+  learnMoreLink?: string;
   learnMoreLabel2?: string;
   learnMoreLink2?: string;
   error?: unknown;
@@ -240,7 +240,7 @@ export const Filter: FC<FilterProps> = ({
 
 interface PresetMenuProps {
   presets: PresetFilter[];
-  learnMoreLink: string;
+  learnMoreLink?: string;
   learnMoreLabel2?: string;
   learnMoreLink2?: string;
   onSelect: (query: string) => void;
@@ -293,19 +293,23 @@ const PresetMenu: FC<PresetMenuProps> = ({
             {presetFilter.name}
           </MenuItem>
         ))}
-        <Divider css={{ borderColor: theme.palette.divider }} />
-        <MenuItem
-          component="a"
-          href={learnMoreLink}
-          target="_blank"
-          css={{ fontSize: 13, fontWeight: 500 }}
-          onClick={() => {
-            setIsOpen(false);
-          }}
-        >
-          <OpenInNewOutlined css={{ fontSize: "14px !important" }} />
-          View advanced filtering
-        </MenuItem>
+        {learnMoreLink && (
+          <>
+            <Divider css={{ borderColor: theme.palette.divider }} />
+            <MenuItem
+              component="a"
+              href={learnMoreLink}
+              target="_blank"
+              css={{ fontSize: 13, fontWeight: 500 }}
+              onClick={() => {
+                setIsOpen(false);
+              }}
+            >
+              <OpenInNewOutlined css={{ fontSize: "14px !important" }} />
+              View advanced filtering
+            </MenuItem>
+          </>
+        )}
         {learnMoreLink2 && learnMoreLabel2 && (
           <MenuItem
             component="a"
diff --git a/site/src/pages/TemplatesPage/TemplatesFilter.tsx b/site/src/pages/TemplatesPage/TemplatesFilter.tsx
@@ -45,7 +45,8 @@ export const TemplatesFilter: FC<TemplatesFilterProps> = ({ filter }) => {
         { query: "", name: "All templates" },
         { query: "deprecated:true", name: "Deprecated templates" },
       ]}
-      learnMoreLink={docs("/templates#template-filtering")}
+      // TODO: Add docs for this
+      // learnMoreLink={docs("/templates#template-filtering")}
       isLoading={false}
       filter={filter}
       options={
diff --git a/site/src/pages/TemplatesPage/TemplatesPageView.tsx b/site/src/pages/TemplatesPage/TemplatesPageView.tsx
@@ -217,11 +217,9 @@ export const TemplatesPageView: FC<TemplatesPageViewProps> = ({
             <TemplateHelpTooltip />
           </Stack>
         </PageHeaderTitle>
-        {templates && templates.length > 0 && (
-          <PageHeaderSubtitle>
-            Select a template to create a workspace.
-          </PageHeaderSubtitle>
-        )}
+        <PageHeaderSubtitle>
+          Select a template to create a workspace.
+        </PageHeaderSubtitle>
       </PageHeader>
 
       <TemplatesFilter filter={filter} />
