Apply review suggestions

BrunoQuaresma · BrunoQuaresma · commit 60cb0559da72 · 2024-11-06T17:31:33.000Z
diff --git a/codersdk/name_test.go b/codersdk/name_test.go
@@ -3,13 +3,12 @@ package codersdk_test
 import (
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"golang.org/x/exp/rand"
 
 	"github.com/coder/coder/v2/codersdk"
+	"github.com/coder/coder/v2/cryptorand"
 	"github.com/coder/coder/v2/testutil"
 )
 
@@ -260,6 +259,11 @@ func TestUserRealNameValid(t *testing.T) {
 func TestGroupNameValid(t *testing.T) {
 	t.Parallel()
 
+	random255String, err := cryptorand.String(255)
+	require.NoError(t, err, "failed to generate 255 random string")
+	random256String, err := cryptorand.String(256)
+	require.NoError(t, err, "failed to generate 256 random string")
+
 	testCases := []struct {
 		Name  string
 		Valid bool
@@ -269,27 +273,23 @@ func TestGroupNameValid(t *testing.T) {
 		{"create", false},
 		{"new", false},
 		{"Lord Voldemort Team", false},
-		{randomString(255), true},
-		{randomString(256), false},
+		{random255String, true},
+		{random256String, false},
 	}
 	for _, testCase := range testCases {
 		testCase := testCase
 		t.Run(testCase.Name, func(t *testing.T) {
 			t.Parallel()
 			err := codersdk.GroupNameValid(testCase.Name)
-			assert.Equal(t, testCase.Valid, err == nil)
+			assert.Equal(
+				t,
+				testCase.Valid,
+				err == nil,
+				"Test case %s failed: expected valid=%t but got error: %v",
+				testCase.Name,
+				testCase.Valid,
+				err,
+			)
 		})
 	}
 }
-
-const charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
-
-// RandomString generates a random string of a given length.
-func randomString(length int) string {
-	seededRand := rand.New(rand.NewSource(uint64(time.Now().UnixNano())))
-	result := make([]byte, length)
-	for i := range result {
-		result[i] = charset[seededRand.Intn(len(charset))]
-	}
-	return string(result)
-}
