fix: appease the linter gods

johnstcn · johnstcn · commit 6129dd9dc6fc · 2022-04-05T20:51:11.000Z
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -1208,7 +1208,7 @@ func (q *fakeQuerier) UpdateProvisionerJobWithCompleteByID(_ context.Context, ar
 	return sql.ErrNoRows
 }
 
-func (q *fakeQuerier) UpdateWorkspaceAutostart(ctx context.Context, arg database.UpdateWorkspaceAutostartParams) error {
+func (q *fakeQuerier) UpdateWorkspaceAutostart(_ context.Context, arg database.UpdateWorkspaceAutostartParams) error {
 	q.mutex.Lock()
 	defer q.mutex.Unlock()
 
@@ -1224,7 +1224,7 @@ func (q *fakeQuerier) UpdateWorkspaceAutostart(ctx context.Context, arg database
 	return sql.ErrNoRows
 }
 
-func (q *fakeQuerier) UpdateWorkspaceAutostop(ctx context.Context, arg database.UpdateWorkspaceAutostopParams) error {
+func (q *fakeQuerier) UpdateWorkspaceAutostop(_ context.Context, arg database.UpdateWorkspaceAutostopParams) error {
 	q.mutex.Lock()
 	defer q.mutex.Unlock()
 
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -321,8 +321,6 @@ func (api *api) putWorkspaceAutostart(rw http.ResponseWriter, r *http.Request) {
 		})
 		return
 	}
-
-	return
 }
 
 // TODO(cian): api.updateWorkspaceAutostop
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -187,6 +187,7 @@ func TestWorkspaceBuildByName(t *testing.T) {
 }
 
 func TestWorkspaceUpdateAutostart(t *testing.T) {
+	t.Parallel()
 	var dublinLoc = mustLocation(t, "Europe/Dublin")
 
 	testCases := []struct {
@@ -251,6 +252,7 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {
 	for _, testCase := range testCases {
 		testCase := testCase
 		t.Run(testCase.name, func(t *testing.T) {
+			t.Parallel()
 			var (
 				ctx       = context.Background()
 				client    = coderdtest.New(t, nil)

Original file line number	Diff line number	Diff line change
`@@ -1208,7 +1208,7 @@ func (q *fakeQuerier) UpdateProvisionerJobWithCompleteByID(_ context.Context, ar`
`1208`	`1208`	`return sql.ErrNoRows`
`1209`	`1209`	`}`
`1210`	`1210`
`1211`		`-func (q *fakeQuerier) UpdateWorkspaceAutostart(ctx context.Context, arg database.UpdateWorkspaceAutostartParams) error {`
	`1211`	`+func (q *fakeQuerier) UpdateWorkspaceAutostart(_ context.Context, arg database.UpdateWorkspaceAutostartParams) error {`
`1212`	`1212`	`q.mutex.Lock()`
`1213`	`1213`	`defer q.mutex.Unlock()`
`1214`	`1214`
`@@ -1224,7 +1224,7 @@ func (q *fakeQuerier) UpdateWorkspaceAutostart(ctx context.Context, arg database`
`1224`	`1224`	`return sql.ErrNoRows`
`1225`	`1225`	`}`
`1226`	`1226`
`1227`		`-func (q *fakeQuerier) UpdateWorkspaceAutostop(ctx context.Context, arg database.UpdateWorkspaceAutostopParams) error {`
	`1227`	`+func (q *fakeQuerier) UpdateWorkspaceAutostop(_ context.Context, arg database.UpdateWorkspaceAutostopParams) error {`
`1228`	`1228`	`q.mutex.Lock()`
`1229`	`1229`	`defer q.mutex.Unlock()`
`1230`	`1230`
Original file line number	Diff line number	Diff line change
`@@ -321,8 +321,6 @@ func (api api) putWorkspaceAutostart(rw http.ResponseWriter, r http.Request) {`
`321`	`321`	`})`
`322`	`322`	`return`
`323`	`323`	`}`
`324`		`-`
`325`		`- return`
`326`	`324`	`}`
`327`	`325`
`328`	`326`	`// TODO(cian): api.updateWorkspaceAutostop`