More reconnectingPTY logging

spikecurtis · spikecurtis · commit 620a57efe7fe · 2023-04-25T06:55:05.000Z
Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;
diff --git a/agent/agent.go b/agent/agent.go
@@ -1038,12 +1038,14 @@ func (a *agent) handleReconnectingPTY(ctx context.Context, logger slog.Logger, m
 			// 1. The timeout completed.
 			// 2. The parent context was canceled.
 			<-ctx.Done()
+			logger.Debug(ctx, "context done", slog.Error(ctx.Err()))
 			_ = process.Kill()
 		}()
 		go func() {
 			// If the process dies randomly, we should
 			// close the pty.
-			_ = process.Wait()
+			err := process.Wait()
+			logger.Debug(ctx, "process exited", slog.Error(err))
 			rpty.Close()
 		}()
 		if err = a.trackConnGoroutine(func() {
@@ -1052,6 +1054,8 @@ func (a *agent) handleReconnectingPTY(ctx context.Context, logger slog.Logger, m
 				read, err := rpty.ptty.OutputReader().Read(buffer)
 				if err != nil {
 					// When the PTY is closed, this is triggered.
+					// Error is typically a benign EOF, so only log for debugging.
+					logger.Debug(ctx, "PTY output read error", slog.Error(err))
 					break
 				}
 				part := buffer[:read]
@@ -1063,8 +1067,14 @@ func (a *agent) handleReconnectingPTY(ctx context.Context, logger slog.Logger, m
 					break
 				}
 				rpty.activeConnsMutex.Lock()
-				for _, conn := range rpty.activeConns {
-					_, _ = conn.Write(part)
+				for cid, conn := range rpty.activeConns {
+					_, err = conn.Write(part)
+					logger.Debug(ctx,
+						"wrote to active conn",
+						slog.F("other_conn_id", cid),
+						slog.F("data", part),
+						slog.Error(err),
+					)
 				}
 				rpty.activeConnsMutex.Unlock()
 			}
