Fix test with better handling of sql.ErrNoRows in coderd

mafredri · mafredri · commit 62fa273f8b56 · 2022-05-10T07:29:06.000Z
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -81,14 +81,16 @@ func (api *api) templateVersionsByTemplate(rw http.ResponseWriter, r *http.Reque
 		return
 	}
 
+	apiVersion := []codersdk.TemplateVersion{}
 	versions, err := api.Database.GetTemplateVersionsByTemplateID(r.Context(), database.GetTemplateVersionsByTemplateIDParams{
 		TemplateID: template.ID,
 		AfterID:    paginationParams.AfterID,
 		LimitOpt:   int32(paginationParams.Limit),
 		OffsetOpt:  int32(paginationParams.Offset),
 	})
 	if errors.Is(err, sql.ErrNoRows) {
-		err = nil
+		httpapi.Write(rw, http.StatusOK, apiVersion)
+		return
 	}
 	if err != nil {
 		httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
@@ -112,7 +114,6 @@ func (api *api) templateVersionsByTemplate(rw http.ResponseWriter, r *http.Reque
 		jobByID[job.ID.String()] = job
 	}
 
-	apiVersion := make([]codersdk.TemplateVersion, 0)
 	for _, version := range versions {
 		job, exists := jobByID[version.JobID.String()]
 		if !exists {
