Force valid dates

Emyrk · Emyrk · commit 64c2cba0718f · 2023-03-01T13:28:00.000-06:00
diff --git a/coderd/httpapi/queryparams.go b/coderd/httpapi/queryparams.go
@@ -89,9 +89,15 @@ func (p *QueryParamParser) UUIDs(vals url.Values, def []uuid.UUID, queryParam st
 }
 
 func (p *QueryParamParser) Time(vals url.Values, def time.Time, queryParam string, format string) time.Time {
-	v, _ := parseQueryParam(p, vals, func(v string) (time.Time, error) {
+	v, err := parseQueryParam(p, vals, func(v string) (time.Time, error) {
 		return time.Parse(queryParam, format)
 	}, def, queryParam)
+	if err != nil {
+		p.Errors = append(p.Errors, codersdk.ValidationError{
+			Field:  queryParam,
+			Detail: fmt.Sprintf("Query param %q must be a valid date format (%s)", format, queryParam),
+		})
+	}
 	return v
 }
 
diff --git a/coderd/searchquery/search_test.go b/coderd/searchquery/search_test.go
@@ -164,6 +164,57 @@ func TestSearchWorkspace(t *testing.T) {
 	})
 }
 
+func TestSearchAudit(t *testing.T) {
+	t.Parallel()
+	testCases := []struct {
+		Name                  string
+		Query                 string
+		Expected              database.GetAuditLogsOffsetParams
+		ExpectedErrorContains string
+	}{
+		{
+			Name:     "Empty",
+			Query:    "",
+			Expected: database.GetAuditLogsOffsetParams{},
+		},
+		// Failures
+		{
+			Name:                  "ExtraColon",
+			Query:                 `search:name:extra`,
+			ExpectedErrorContains: "can only contain 1 ':'",
+		},
+		{
+			Name:                  "ExtraKeys",
+			Query:                 `foo:bar`,
+			ExpectedErrorContains: `Query param "foo" is not a valid query param`,
+		},
+		{
+			Name:                  "Dates",
+			Query:                 "date_from:2006",
+			ExpectedErrorContains: "valid date format",
+		},
+	}
+
+	for _, c := range testCases {
+		c := c
+		t.Run(c.Name, func(t *testing.T) {
+			t.Parallel()
+			values, errs := searchquery.Audit(c.Query)
+			if c.ExpectedErrorContains != "" {
+				require.True(t, len(errs) > 0, "expect some errors")
+				var s strings.Builder
+				for _, err := range errs {
+					_, _ = s.WriteString(fmt.Sprintf("%s: %s\n", err.Field, err.Detail))
+				}
+				require.Contains(t, s.String(), c.ExpectedErrorContains)
+			} else {
+				require.Len(t, errs, 0, "expected no error")
+				require.Equal(t, c.Expected, values, "expected values")
+			}
+		})
+	}
+}
+
 func TestSearchUsers(t *testing.T) {
 	t.Parallel()
 	testCases := []struct {
