nit: trim smarthost

DanielleMaywood · DanielleMaywood · commit 66d1a6943d6e · 2024-11-13T10:45:42.000Z
diff --git a/coderd/notifications/dispatch/smtp.go b/coderd/notifications/dispatch/smtp.go
@@ -520,11 +520,12 @@ func (s *SMTPHandler) validateToAddrs(to string) ([]string, error) {
 // Does not allow overriding.
 // nolint:revive // documented.
 func (s *SMTPHandler) smarthost() (string, string, error) {
-	if s.cfg.Smarthost.String() == "" {
+	hostport := strings.TrimSpace(s.cfg.Smarthost.String())
+	if hostport == "" {
 		return "", "", ValidationNoSmarthostErr
 	}
 
-	host, port, err := net.SplitHostPort(s.cfg.Smarthost.String())
+	host, port, err := net.SplitHostPort(hostport)
 	if err != nil {
 		return "", "", xerrors.Errorf("split host port: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -520,11 +520,12 @@ func (s *SMTPHandler) validateToAddrs(to string) ([]string, error) {`
`520`	`520`	`// Does not allow overriding.`
`521`	`521`	`// nolint:revive // documented.`
`522`	`522`	`func (s *SMTPHandler) smarthost() (string, string, error) {`
`523`		`- if s.cfg.Smarthost.String() == "" {`
	`523`	`+ hostport := strings.TrimSpace(s.cfg.Smarthost.String())`
	`524`	`+ if hostport == "" {`
`524`	`525`	`return "", "", ValidationNoSmarthostErr`
`525`	`526`	`}`
`526`	`527`
`527`		`- host, port, err := net.SplitHostPort(s.cfg.Smarthost.String())`
	`528`	`+ host, port, err := net.SplitHostPort(hostport)`
`528`	`529`	`if err != nil {`
`529`	`530`	`return "", "", xerrors.Errorf("split host port: %w", err)`
`530`	`531`	`}`