fix: updates for PR review

jaaydenh · jaaydenh · commit 6711e28aa7e9 · 2025-05-15T21:48:18.000Z
diff --git a/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx b/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
@@ -514,7 +514,6 @@ export const MultiSelectCombobox = forwardRef<
 							})}
 							{/* Avoid having the "Search" Icon */}
 							<CommandPrimitive.Input
-								id={inputProps?.id}
 								{...inputProps}
 								ref={inputRef}
 								value={inputValue}
diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -42,7 +42,7 @@ import * as Yup from "yup";
 export interface DynamicParameterProps {
 	parameter: PreviewParameter;
 	value?: string;
-	onChange: (value: string) => Promise<void>;
+	onChange: (value: string) => void;
 	disabled?: boolean;
 	isPreset?: boolean;
 	autofill: boolean;
@@ -203,7 +203,7 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
 interface DebouncedParameterFieldProps {
 	parameter: PreviewParameter;
 	value?: string;
-	onChange: (value: string) => Promise<void>;
+	onChange: (value: string) => void;
 	disabled?: boolean;
 	id: string;
 }
@@ -239,12 +239,12 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
 					className="max-w-2xl"
 					value={localValue}
 					onChange={(e) => {
-						setLocalValue(e.target.value);
-					}}
-					onInput={(e) => {
 						const target = e.currentTarget;
+						target.style.height = "auto";
 						target.style.maxHeight = "700px";
 						target.style.height = `${target.scrollHeight}px`;
+
+						setLocalValue(e.target.value);
 					}}
 					disabled={disabled}
 					placeholder={parameter.styling?.placeholder}
@@ -290,7 +290,7 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
 interface ParameterFieldProps {
 	parameter: PreviewParameter;
 	value?: string;
-	onChange: (value: string) => Promise<void>;
+	onChange: (value: string) => void;
 	disabled?: boolean;
 	id: string;
 }
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
@@ -50,7 +50,7 @@ const CreateWorkspacePageExperimental: FC = () => {
 
 	const [currentResponse, setCurrentResponse] =
 		useState<DynamicParametersResponse | null>(null);
-	const [wsResponseId, setWSResponseId] = useState<number>(-1);
+	const wsResponseId = useRef<number>(-1);
 	const ws = useRef<WebSocket | null>(null);
 	const [wsError, setWsError] = useState<Error | null>(null);
 	const initialParamsSentRef = useRef(false);
@@ -88,23 +88,17 @@ const CreateWorkspacePageExperimental: FC = () => {
 	const realizedVersionId =
 		customVersionId ?? templateQuery.data?.active_version_id;
 
-	const autofillParameters = useMemo(
-		() => getAutofillParameters(searchParams),
-		[searchParams],
-	);
+	const autofillParameters = getAutofillParameters(searchParams);
 
 	const sendMessage = useCallback((formValues: Record<string, string>) => {
-		setWSResponseId((prevId) => {
 			const request: DynamicParametersRequest = {
-				id: prevId + 1,
+				id: wsResponseId.current + 1,
 				inputs: formValues,
 			};
 			if (ws.current && ws.current.readyState === WebSocket.OPEN) {
 				ws.current.send(JSON.stringify(request));
-				return prevId + 1;
+				wsResponseId.current = wsResponseId.current + 1;
 			}
-			return prevId;
-		});
 	}, []);
 
 	// On sends all initial parameter values to the websocket
@@ -140,7 +134,7 @@ const CreateWorkspacePageExperimental: FC = () => {
 	const onMessage = useCallback(
 		(response: DynamicParametersResponse) => {
 			setCurrentResponse((prev) => {
-				if (prev?.id === response.id) {
+				if (prev && prev?.id >= response.id) {
 					return prev;
 				}
 
