RBAC (unfinished) and style tweak

presleyp · presleyp · commit 6719ed6be7a1 · 2022-08-30T19:29:45.000Z
diff --git a/site/src/pages/TemplatePage/TemplatePage.tsx b/site/src/pages/TemplatePage/TemplatePage.tsx
@@ -1,9 +1,11 @@
-import { useMachine } from "@xstate/react"
+import { useMachine, useSelector } from "@xstate/react"
 import { ConfirmDialog } from "components/ConfirmDialog/ConfirmDialog"
-import { FC } from "react"
+import { FC, useContext } from "react"
 import { Helmet } from "react-helmet-async"
 import { useTranslation } from "react-i18next"
 import { Navigate, useParams } from "react-router-dom"
+import { selectPermissions } from "xServices/auth/authSelectors"
+import { XServiceContext } from "xServices/StateContext"
 import { Loader } from "../../components/Loader/Loader"
 import { useOrganizationId } from "../../hooks/useOrganizationId"
 import { pageTitle } from "../../util/page"
@@ -37,7 +39,9 @@ export const TemplatePage: FC<React.PropsWithChildren<unknown>> = () => {
     templateVersions,
     deleteTemplateError,
   } = templateState.context
-  const isLoading = !template || !activeTemplateVersion || !templateResources
+  const xServices = useContext(XServiceContext)
+  const permissions = useSelector(xServices.authXService, selectPermissions)
+  const isLoading = !template || !activeTemplateVersion || !templateResources || !permissions
 
   const handleDeleteTemplate = () => {
     templateSend("DELETE")
@@ -61,6 +65,7 @@ export const TemplatePage: FC<React.PropsWithChildren<unknown>> = () => {
         activeTemplateVersion={activeTemplateVersion}
         templateResources={templateResources}
         templateVersions={templateVersions}
+        canDeleteTemplate={permissions.deleteTemplates}
         handleDeleteTemplate={handleDeleteTemplate}
         deleteTemplateError={deleteTemplateError}
       />
diff --git a/site/src/pages/TemplatePage/TemplatePageView.tsx b/site/src/pages/TemplatePage/TemplatePageView.tsx
@@ -41,6 +41,7 @@ export interface TemplatePageViewProps {
   templateVersions?: TemplateVersion[]
   handleDeleteTemplate: (templateId: string) => void
   deleteTemplateError: Error | unknown
+  canDeleteTemplate: boolean
 }
 
 export const TemplatePageView: FC<React.PropsWithChildren<TemplatePageViewProps>> = ({
@@ -50,6 +51,7 @@ export const TemplatePageView: FC<React.PropsWithChildren<TemplatePageViewProps>
   templateVersions,
   handleDeleteTemplate,
   deleteTemplateError,
+  canDeleteTemplate
 }) => {
   const styles = useStyles()
   const readme = frontMatter(activeTemplateVersion.readme)
@@ -59,6 +61,15 @@ export const TemplatePageView: FC<React.PropsWithChildren<TemplatePageViewProps>
     return resources.filter((resource) => resource.workspace_transition === "start")
   }
 
+  const createWorkspaceButton = (className: string) => <Link
+                  underline="none"
+                  component={RouterLink}
+                  to={`/templates/${template.name}/workspace`}
+                >
+                  <Button className={className} startIcon={<AddCircleOutline />}>{Language.createButton}</Button>
+                </Link>
+
+
   return (
     <Margins>
       <>
@@ -76,24 +87,20 @@ export const TemplatePageView: FC<React.PropsWithChildren<TemplatePageViewProps>
               </Button>
             </Link>
 
-            <DropdownButton
-              primaryAction={
-                <Link
-                  underline="none"
-                  component={RouterLink}
-                  to={`/templates/${template.name}/workspace`}
-                >
-                  <Button startIcon={<AddCircleOutline />}>{Language.createButton}</Button>
-                </Link>
-              }
-              secondaryActions={[
-                {
-                  action: "delete",
-                  button: <DeleteButton handleAction={() => handleDeleteTemplate(template.id)} />,
-                },
-              ]}
-              canCancel={false}
-            />
+            {canDeleteTemplate ?
+              <DropdownButton
+                primaryAction={createWorkspaceButton(styles.actionButton)}
+                secondaryActions={[
+                  {
+                    action: "delete",
+                    button: <DeleteButton handleAction={() => handleDeleteTemplate(template.id)} />,
+                  },
+                ]}
+                canCancel={false}
+              />
+            :
+              createWorkspaceButton("")
+            }
           </Stack>
         }
       >
@@ -156,6 +163,10 @@ export const TemplatePageView: FC<React.PropsWithChildren<TemplatePageViewProps>
 
 export const useStyles = makeStyles((theme) => {
   return {
+    actionButton: {
+      border: "none",
+      borderRadius: `${theme.shape.borderRadius}px 0px 0px ${theme.shape.borderRadius}px`,
+    },
     readmeContents: {
       margin: 0,
     },
diff --git a/site/src/xServices/auth/authXService.ts b/site/src/xServices/auth/authXService.ts
@@ -14,6 +14,7 @@ export const checks = {
   updateUsers: "updateUsers",
   createUser: "createUser",
   createTemplates: "createTemplates",
+  deleteTemplates: "deleteTemplates",
   viewAuditLog: "viewAuditLog",
 } as const
 
@@ -42,6 +43,12 @@ export const permissionsToCheck = {
     },
     action: "update",
   },
+  [checks.deleteTemplates]: {
+    object: {
+      resource_type: "template"
+    },
+    action: "delete"
+  },
   [checks.viewAuditLog]: {
     object: {
       resource_type: "audit_log",
