WIP

mtojek · mtojek · commit 679e205444ec · 2023-08-25T16:38:44.000+02:00
diff --git a/site/e2e/helpers.ts b/site/e2e/helpers.ts
@@ -19,6 +19,7 @@ import { port } from "./playwright.config"
 import * as ssh from "ssh2"
 import { Duplex } from "stream"
 import { WorkspaceBuildParameter } from "api/typesGenerated"
+import { createTemplateVersion, uploadTemplateFile } from "api/api"
 
 // createWorkspace creates a workspace for a template.
 // It does not wait for it to be running, but it does navigate to the page.
@@ -615,3 +616,24 @@ export const fillParameters = async (
     }
   }
 }
+
+export const uploadTemplateVersion = async (
+  templateName: string,
+  responses?: EchoProvisionerResponses,
+): Promise<string> => {
+  const tarball = await createTemplateVersionTar(responses)
+  const file = new File([tarball], "version.tar", { type: "application/x-tar" })
+  const uploadResponse = await uploadTemplateFile(file)
+
+  // FIXME find:
+  const organizationId = ""
+  const templateId = ""
+  const templateVersion = await createTemplateVersion(organizationId, {
+    template_id: templateId,
+    storage_method: "file",
+    file_id: uploadResponse.hash,
+    provisioner: "echo",
+    tags: {},
+  })
+  return templateVersion.id
+}
diff --git a/site/e2e/tests/createWorkspace.spec.ts b/site/e2e/tests/createWorkspace.spec.ts
@@ -107,6 +107,7 @@ test("create workspace and overwrite default parameters", async ({ page }) => {
     page,
     echoResponsesWithParameters(richParameters),
   )
+
   const workspaceName = await createWorkspace(
     page,
     template,
diff --git a/site/e2e/tests/updateWorkspace.spec.ts b/site/e2e/tests/updateWorkspace.spec.ts
@@ -0,0 +1,49 @@
+import { test } from "@playwright/test"
+import {
+  createTemplate,
+  createWorkspace,
+  echoResponsesWithParameters,
+  uploadTemplateVersion,
+  verifyParameters,
+} from "../helpers"
+
+import { fifthParameter, firstParameter, secondParameter } from "../parameters"
+import { RichParameter } from "../provisionerGenerated"
+
+test("update workspace, new optional, mutable parameter added", async ({
+  page,
+}) => {
+  const richParameters: RichParameter[] = [firstParameter, secondParameter]
+  const template = await createTemplate(
+    page,
+    echoResponsesWithParameters(richParameters),
+  )
+
+  const workspaceName = await createWorkspace(page, template)
+
+  // Verify that parameter values are default.
+  await verifyParameters(page, workspaceName, richParameters, [
+    { name: firstParameter.name, value: firstParameter.defaultValue },
+    { name: secondParameter.name, value: secondParameter.defaultValue },
+  ])
+
+  // Upload new template version with extra parameter.
+  const updatedRichParameters = [...richParameters, fifthParameter]
+  const templateVersion = await uploadTemplateVersion(
+    template,
+    echoResponsesWithParameters(updatedRichParameters),
+  )
+
+  // TODO Activate the template version
+  // Go to Versions -> Promote version
+
+  // Now, update the workspace.
+  // TODO Update workspace
+
+  // Verify that parameter values are default.
+  await verifyParameters(page, workspaceName, updatedRichParameters, [
+    { name: firstParameter.name, value: firstParameter.defaultValue },
+    { name: secondParameter.name, value: secondParameter.defaultValue },
+    { name: fifthParameter.name, value: fifthParameter.defaultValue },
+  ])
+})

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ test("create workspace and overwrite default parameters", async ({ page }) => {`
`107`	`107`	`page,`
`108`	`108`	`echoResponsesWithParameters(richParameters),`
`109`	`109`	`)`
	`110`	`+`
`110`	`111`	`const workspaceName = await createWorkspace(`
`111`	`112`	`page,`
`112`	`113`	`template,`