amend pr feedback

mafredri · mafredri · commit 6898381e6115 · 2024-04-24T13:27:32.000+03:00
diff --git a/scripts/release/main.go b/scripts/release/main.go
@@ -96,7 +96,7 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger
 	// Check if the version is already the latest stable release.
 	currentStable, _, err := client.Repositories.GetLatestRelease(ctx, "coder", "coder")
 	if err != nil {
-		return err
+		return xerrors.Errorf("get latest release failed: %w", err)
 	}
 
 	logger = logger.With(slog.F("stable_version", currentStable.GetTagName()))
@@ -113,7 +113,7 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger
 		PerPage: perPage,
 	})
 	if err != nil {
-		return err
+		return xerrors.Errorf("list releases failed: %w", err)
 	}
 
 	var releaseVersions []string
@@ -164,9 +164,9 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger
 	if !dryRun {
 		_, _, err = client.Repositories.EditRelease(ctx, owner, repo, newStable.GetID(), newStable)
 		if err != nil {
-			return err
+			return xerrors.Errorf("edit release failed: %w", err)
 		}
-		logger.Info(ctx, "selected version promoted to stable")
+		logger.Info(ctx, "selected version promoted to stable", "url", newStable.GetHTMLURL())
 	} else {
 		logger.Info(ctx, "dry-run: release not updated", "uncommitted_changes", cmp.Diff(newStable, updatedNewStable))
 	}
diff --git a/scripts/release/main_test.go b/scripts/release/main_test.go
@@ -86,6 +86,26 @@ Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/code
 ## Install/upgrade
 
 Refer to our docs to [install](https://coder.com/docs/v2/latest/install) or [upgrade](https://coder.com/docs/v2/latest/admin/upgrade) Coder, or use a release asset below.
+`,
+		},
+		{
+			name: "EntireQuotedBlurbIsRemoved",
+			body: `## Changelog
+
+> [!NOTE]
+> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/v2/latest/install/releases).
+> This is an extended note.
+> This is another extended note.
+
+### Best release yet!
+
+Enjoy.
+`,
+			want: `## Changelog
+
+### Best release yet!
+
+Enjoy.
 `,
 		},
 	}
