fix: update type signature of getErrorDetail

Parkreiner · Parkreiner · commit 6935f507edb1 · 2024-07-02T18:12:53.000Z
diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
@@ -110,15 +110,18 @@ export const getValidationErrorMessage = (error: unknown): string => {
   return validationErrors.map((error) => error.detail).join("\n");
 };
 
-export const getErrorDetail = (error: unknown): string | null => {
+export const getErrorDetail = (error: unknown): string | undefined => {
   if (error instanceof Error) {
     return "Please check the developer console for more details.";
   }
+
   if (isApiError(error)) {
-    return error.response.data.detail ?? null;
+    return error.response.data.detail;
   }
+
   if (isApiErrorResponse(error)) {
-    return error.detail ?? null;
+    return error.detail;
   }
-  return null;
+
+  return undefined;
 };
