fix: disable agent app buttons until startup script is completes when set to blocking

aslilac · aslilac · commit 6ad1dfe7bf23 · 2024-06-25T21:31:49.000Z
diff --git a/site/src/modules/resources/AppLink/AppLink.tsx b/site/src/modules/resources/AppLink/AppLink.tsx
@@ -16,7 +16,7 @@ import { ShareIcon } from "./ShareIcon";
 export const DisplayAppNameMap: Record<TypesGen.DisplayApp, string> = {
   port_forwarding_helper: "Ports",
   ssh_helper: "SSH",
-  vscode: "VS Code Desktop",
+  vscode: "VS Code",
   vscode_insiders: "VS Code Insiders",
   web_terminal: "Terminal",
 };
@@ -94,19 +94,19 @@ export const AppLink: FC<AppLinkProps> = ({ app, workspace, agent }) => {
   }
   if (!appsHost && app.subdomain) {
     canClick = false;
-    icon = (
-      <ErrorOutlineIcon
-        css={{
-          color: theme.palette.grey[300],
-        }}
-      />
-    );
+    icon = <ErrorOutlineIcon css={{ color: theme.palette.grey[300] }} />;
     primaryTooltip =
       "Your admin has not configured subdomain application access";
   }
   if (fetchingSessionToken) {
     canClick = false;
   }
+  if (
+    agent.lifecycle_state === "starting" &&
+    agent.startup_script_behavior === "blocking"
+  ) {
+    canClick = false;
+  }
 
   const isPrivateApp = app.sharing_level === "owner";
 
