Pass transaction into report generator to avoid deadlock

dannykopping · dannykopping · commit 6add98fff70e · 2024-09-30T14:19:58.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/notifications/reports/generator.go b/coderd/notifications/reports/generator.go
@@ -49,7 +49,7 @@ func NewReportGenerator(ctx context.Context, logger slog.Logger, db database.Sto
 				return nil
 			}
 
-			err = reportFailedWorkspaceBuilds(ctx, logger, db, enqueuer, clk)
+			err = reportFailedWorkspaceBuilds(ctx, logger, tx, enqueuer, clk)
 			if err != nil {
 				return xerrors.Errorf("unable to generate reports with failed workspace builds: %w", err)
 			}

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func NewReportGenerator(ctx context.Context, logger slog.Logger, db database.Sto`
`49`	`49`	`return nil`
`50`	`50`	`}`
`51`	`51`
`52`		`- err = reportFailedWorkspaceBuilds(ctx, logger, db, enqueuer, clk)`
	`52`	`+ err = reportFailedWorkspaceBuilds(ctx, logger, tx, enqueuer, clk)`
`53`	`53`	`if err != nil {`
`54`	`54`	`return xerrors.Errorf("unable to generate reports with failed workspace builds: %w", err)`
`55`	`55`	`}`