Apply PR review suggestions

BrunoQuaresma · BrunoQuaresma · commit 6ae6efea0e2f · 2025-05-06T22:51:51.000Z
diff --git a/site/src/modules/apps/apps.ts b/site/src/modules/apps/apps.ts
@@ -1,5 +1,3 @@
-import { generateRandomString } from "utils/random";
-
 type GetVSCodeHrefParams = {
 	owner: string;
 	workspace: string;
@@ -52,9 +50,5 @@ export const getTerminalHref = ({
 };
 
 export const openAppInNewWindow = (name: string, href: string) => {
-	window.open(
-		href,
-		`${name} - ${generateRandomString(12)}`,
-		"width=900,height=600",
-	);
+	window.open(href, "_blank", "width=900,height=600");
 };
diff --git a/site/src/modules/resources/VSCodeDesktopButton/VSCodeDesktopButton.tsx b/site/src/modules/resources/VSCodeDesktopButton/VSCodeDesktopButton.tsx
@@ -119,15 +119,13 @@ const VSCodeButton: FC<VSCodeDesktopButtonProps> = ({
 				setLoading(true);
 				API.getApiKey()
 					.then(({ key }) => {
-						const href = getVSCodeHref("vscode", {
+						location.href = getVSCodeHref("vscode", {
 							owner: userName,
 							workspace: workspaceName,
 							token: key,
 							agent: agentName,
 							folder: folderPath,
 						});
-
-						location.href = href;
 					})
 					.catch((ex) => {
 						console.error(ex);
@@ -158,15 +156,13 @@ const VSCodeInsidersButton: FC<VSCodeDesktopButtonProps> = ({
 				setLoading(true);
 				API.getApiKey()
 					.then(({ key }) => {
-						const href = getVSCodeHref("vscode-insiders", {
+						location.href = getVSCodeHref("vscode-insiders", {
 							owner: userName,
 							workspace: workspaceName,
 							token: key,
 							agent: agentName,
 							folder: folderPath,
 						});
-
-						location.href = href;
 					})
 					.catch((ex) => {
 						console.error(ex);
diff --git a/site/src/pages/WorkspacesPage/WorkspacesTable.tsx b/site/src/pages/WorkspacesPage/WorkspacesTable.tsx
@@ -638,7 +638,6 @@ type WorkspaceAppsProps = {
 };
 
 const WorkspaceApps: FC<WorkspaceAppsProps> = ({ workspace }) => {
-	const buttons: ReactNode[] = [];
 	const { data: apiKeyRes } = useQuery(apiKey());
 	const token = apiKeyRes?.key;
 
@@ -654,6 +653,8 @@ const WorkspaceApps: FC<WorkspaceAppsProps> = ({ workspace }) => {
 		return null;
 	}
 
+	const buttons: ReactNode[] = [];
+
 	if (agent.display_apps.includes("vscode")) {
 		buttons.push(
 			<AppLink
