Skip to content

Commit 6b4e763

Browse files
committed
Update chart to support weekly data
1 parent 78e6db0 commit 6b4e763

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

site/src/components/ActiveUserChart/ActiveUserChart.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@ ChartJS.register(
3939

4040
export interface ActiveUserChartProps {
4141
data: { date: string; amount: number }[];
42+
interval: "day" | "week";
4243
}
4344

44-
export const ActiveUserChart: FC<ActiveUserChartProps> = ({ data }) => {
45+
export const ActiveUserChart: FC<ActiveUserChartProps> = ({
46+
data,
47+
interval,
48+
}) => {
4549
const theme: Theme = useTheme();
4650

4751
const labels = data.map((val) => {
@@ -85,7 +89,7 @@ export const ActiveUserChart: FC<ActiveUserChartProps> = ({ data }) => {
8589
},
8690
type: "time",
8791
time: {
88-
unit: "day",
92+
unit: interval,
8993
},
9094
},
9195
},

site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPageView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const GeneralSettingsPageView = ({
3636
{deploymentDAUs && (
3737
<Box height={200} sx={{ mb: 3 }}>
3838
<ChartSection title={<ActiveUsersTitle />}>
39-
<ActiveUserChart data={deploymentDAUs.entries} />
39+
<ActiveUserChart data={deploymentDAUs.entries} interval="day" />
4040
</ChartSection>
4141
</Box>
4242
)}

site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ export default function TemplateInsightsPage() {
112112
}
113113
templateInsights={templateInsights}
114114
userLatency={userLatency}
115+
interval={interval}
115116
/>
116117
</>
117118
);
@@ -121,10 +122,12 @@ export const TemplateInsightsPageView = ({
121122
templateInsights,
122123
userLatency,
123124
controls,
125+
interval,
124126
}: {
125127
templateInsights: TemplateInsightsResponse | undefined;
126128
userLatency: UserLatencyInsightsResponse | undefined;
127129
controls: ReactNode;
130+
interval: InsightsInterval;
128131
}) => {
129132
return (
130133
<>
@@ -148,6 +151,7 @@ export const TemplateInsightsPageView = ({
148151
>
149152
<ActiveUsersPanel
150153
sx={{ gridColumn: "span 2" }}
154+
interval={interval}
151155
data={templateInsights?.interval_reports}
152156
/>
153157
<UserLatencyPanel data={userLatency} />
@@ -166,9 +170,11 @@ export const TemplateInsightsPageView = ({
166170

167171
const ActiveUsersPanel = ({
168172
data,
173+
interval,
169174
...panelProps
170175
}: PanelProps & {
171176
data: TemplateInsightsResponse["interval_reports"] | undefined;
177+
interval: InsightsInterval;
172178
}) => {
173179
return (
174180
<Panel {...panelProps}>
@@ -182,6 +188,7 @@ const ActiveUsersPanel = ({
182188
{data && data.length === 0 && <NoDataAvailable />}
183189
{data && data.length > 0 && (
184190
<ActiveUserChart
191+
interval={interval}
185192
data={data.map((d) => {
186193
return {
187194
amount: d.active_users,

0 commit comments

Comments
 (0)