refactor: CR's fixes

evgeniy-scherbina · evgeniy-scherbina · commit 6c41e03f90b9 · 2025-04-24T12:48:57.000Z
diff --git a/coderd/wsbuilder/wsbuilder.go b/coderd/wsbuilder/wsbuilder.go
@@ -647,11 +647,6 @@ func (b *Builder) findNewBuildParameterValue(name string) *codersdk.WorkspaceBui
 }
 
 func (b *Builder) getLastBuildParameters() ([]database.WorkspaceBuildParameter, error) {
-	// TODO: exclude preset params from this list instead of returning nothing?
-	if b.prebuildClaimedBy != uuid.Nil {
-		return nil, nil
-	}
-
 	if b.lastBuildParameters != nil {
 		return *b.lastBuildParameters, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -647,11 +647,6 @@ func (b Builder) findNewBuildParameterValue(name string) codersdk.WorkspaceBui`
`647`	`647`	`}`
`648`	`648`
`649`	`649`	`func (b *Builder) getLastBuildParameters() ([]database.WorkspaceBuildParameter, error) {`
`650`		`- // TODO: exclude preset params from this list instead of returning nothing?`
`651`		`- if b.prebuildClaimedBy != uuid.Nil {`
`652`		`- return nil, nil`
`653`		`- }`
`654`		`-`
`655`	`650`	`if b.lastBuildParameters != nil {`
`656`	`651`	`return *b.lastBuildParameters, nil`
`657`	`652`	`}`