Reports

mtojek · mtojek · commit 6c59dc3b7f6f · 2023-11-22T19:16:27.000+01:00
diff --git a/coderd/healthcheck/derphealth/derp.go b/coderd/healthcheck/derphealth/derp.go
@@ -154,6 +154,7 @@ func (r *Report) Run(ctx context.Context, opts *ReportOptions) {
 
 func (r *RegionReport) Run(ctx context.Context) {
 	r.Healthy = true
+	r.Severity = health.SeverityOK
 	r.NodeReports = []*NodeReport{}
 
 	wg := &sync.WaitGroup{}
@@ -205,6 +206,13 @@ func (r *RegionReport) Run(ctx context.Context) {
 	} else if healthyNodes < len(r.Region.Nodes) {
 		r.Warnings = append(r.Warnings, oneNodeUnhealthy)
 	}
+
+	// Review node reports and select the highest severing.
+	for _, nodeReport := range r.NodeReports {
+		if nodeReport.Severity.Value() > r.Severity.Value() {
+			r.Severity = nodeReport.Severity
+		}
+	}
 }
 
 func (r *NodeReport) derpURL() *url.URL {
diff --git a/coderd/healthcheck/health/model.go b/coderd/healthcheck/health/model.go
@@ -8,3 +8,13 @@ const (
 
 // @typescript-generate Severity
 type Severity string
+
+var severityRank = map[Severity]int{
+	SeverityOK:      0,
+	SeverityWarning: 1,
+	SeverityError:   2,
+}
+
+func (s Severity) Value() int {
+	return severityRank[s]
+}
diff --git a/coderd/healthcheck/healthcheck.go b/coderd/healthcheck/healthcheck.go
@@ -154,6 +154,22 @@ func Run(ctx context.Context, opts *ReportOptions) *Report {
 	}
 
 	report.Healthy = len(report.FailingSections) == 0
+
+	// Review healthcheck sub-reports.
+	report.Severity = health.SeverityOK
+
+	if report.DERP.Severity.Value() > report.Severity.Value() {
+		report.Severity = report.DERP.Severity
+	}
+	if report.AccessURL.Severity.Value() > report.Severity.Value() {
+		report.Severity = report.AccessURL.Severity
+	}
+	if report.Websocket.Severity.Value() > report.Severity.Value() {
+		report.Severity = report.Websocket.Severity
+	}
+	if report.Database.Severity.Value() > report.Severity.Value() {
+		report.Severity = report.Database.Severity
+	}
 	return &report
 }
 
