refactor(site): match v1 tsconfig; simplify tsconfig.test.json (#426)

G r e y · web-flow · commit 6c83907b1b36 · 2022-03-13T19:54:35.000-04:00
* refactor(site): match v1 tsconfig

Summary of changes:

* ordered configurations for ease of readability
* allowJs removed -&gt; not needed after Next.js
* noImplicitAny removed -&gt; this is set to true by strict
* strictNullChecks removed -&gt; this is set to true by strict
* removed lingering next-env.d.ts in include

* refactor(site): simplify tsconfig.test.json

Because that the base tsconfig was simplified when changing from
Next.js, this one now duplicates most of it. I still believe having a
separate tsconfig is a good idea for the purposes of separating tests
from source code. It especially can make it easier for eslint and jest
performance.
diff --git a/site/tsconfig.json b/site/tsconfig.json
@@ -1,23 +1,20 @@
 {
   "compilerOptions": {
-    "outDir": "./dist/",
-    "noImplicitAny": true,
-    "module": "commonjs",
-    "target": "es5",
-    "jsx": "react",
-    "allowJs": true,
     "downlevelIteration": true,
     "esModuleInterop": true,
-    "resolveJsonModule": true,
+    "forceConsistentCasingInFileNames": true,
+    "incremental": true,
     "isolatedModules": true,
+    "jsx": "react",
     "lib": ["dom", "dom.iterable", "esnext"],
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "outDir": "./dist/",
+    "resolveJsonModule": true,
     "skipLibCheck": true,
     "strict": true,
-    "strictNullChecks": true,
-    "forceConsistentCasingInFileNames": true,
-    "incremental": true,
-    "moduleResolution": "node"
+    "target": "es5"
   },
-  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
+  "include": ["**/*.ts", "**/*.tsx"],
   "exclude": ["node_modules", "_jest", "**/*.test.tsx"]
 }
diff --git a/site/tsconfig.test.json b/site/tsconfig.test.json
@@ -1,13 +1,4 @@
 {
   "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "target": "es5",
-    "module": "commonjs",
-    "jsx": "react",
-    "downlevelIteration": true,
-    "strict": true,
-    "strictNullChecks": true,
-    "esModuleInterop": true
-  },
   "exclude": ["node_modules", "_jest"]
 }

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "./tsconfig.json",`
`3`		`- "compilerOptions": {`
`4`		`- "target": "es5",`
`5`		`- "module": "commonjs",`
`6`		`- "jsx": "react",`
`7`		`- "downlevelIteration": true,`
`8`		`- "strict": true,`
`9`		`- "strictNullChecks": true,`
`10`		`- "esModuleInterop": true`
`11`		`- },`
`12`	`3`	`"exclude": ["node_modules", "_jest"]`
`13`	`4`	`}`