perf: move sort order callback outside loop

Parkreiner · Parkreiner · commit 6cc07b4828a0 · 2023-10-18T14:49:20.000Z
diff --git a/site/src/api/queries/groups.ts b/site/src/api/queries/groups.ts
@@ -45,17 +45,21 @@ export function groupsByUserId(organizationId: string) {
         }
       }
 
-      for (const groupsList of userIdMapper.values()) {
-        groupsList.sort((g1, g2) => {
-          const key =
-            g1.display_name && g2.display_name ? "display_name" : "name";
+      // Defined outside the loop because it can be reused by all group arrays,
+      // and doesn't need to be rebuilt from scratch on each iteration
+      const orderGroupsByName = (g1: Group, g2: Group) => {
+        const key =
+          g1.display_name && g2.display_name ? "display_name" : "name";
+
+        if (g1[key] === g2[key]) {
+          return 0;
+        }
 
-          if (g1[key] === g2[key]) {
-            return 0;
-          }
+        return g1[key] < g2[key] ? -1 : 1;
+      };
 
-          return g1[key] < g2[key] ? -1 : 1;
-        });
+      for (const groupsList of userIdMapper.values()) {
+        groupsList.sort(orderGroupsByName);
       }
 
       return userIdMapper as GroupsByUserId;
