fix: remove useEffect

jaaydenh · jaaydenh · commit 6e2ee0885c9e · 2024-12-02T23:07:09.000Z
diff --git a/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx b/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
@@ -202,6 +202,12 @@ export const MultiSelectCombobox = React.forwardRef<
 		const [inputValue, setInputValue] = React.useState("");
 		const debouncedSearchTerm = useDebouncedValue(inputValue, delay || 500);
 
+		const [previousValue, setPreviousValue] = React.useState<Option[]>(value || []);
+		if (value && value !== previousValue) {
+			setPreviousValue(value);
+			setSelected(value);
+		}
+
 		React.useImperativeHandle(
 			ref,
 			() => ({
@@ -272,12 +278,6 @@ export const MultiSelectCombobox = React.forwardRef<
 			};
 		}, [open]);
 
-		useEffect(() => {
-			if (value) {
-				setSelected(value);
-			}
-		}, [value]);
-
 		useEffect(() => {
 			/** If `onSearch` is provided, do not trigger options updated. */
 			if (!arrayOptions || onSearch) {
