chore: use strings.Builder

DanielleMaywood · DanielleMaywood · commit 6e59ecbce6c2 · 2024-09-04T10:18:49.000Z
diff --git a/cli/cliui/select.go b/cli/cliui/select.go
@@ -175,21 +175,25 @@ func (m selectModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 }
 
 func (m selectModel) View() string {
-	var s string
+	var s strings.Builder
 
 	msg := pretty.Sprintf(pretty.Bold(), "? %s", m.message)
 
 	if m.selected != "" {
 		selected := pretty.Sprint(DefaultStyles.Keyword, m.selected)
-		s += fmt.Sprintf("%s %s\n", msg, selected)
+		_, _ = s.WriteString(fmt.Sprintf("%s %s\n", msg, selected))
 
-		return s
+		return s.String()
 	}
 
 	if m.hideSearch {
-		s += fmt.Sprintf("%s [Use arrows to move]\n", msg)
+		_, _ = s.WriteString(fmt.Sprintf("%s [Use arrows to move]\n", msg))
 	} else {
-		s += fmt.Sprintf("%s %s[Use arrows to move, type to filter]\n", msg, m.search.View())
+		_, _ = s.WriteString(fmt.Sprintf(
+			"%s %s[Use arrows to move, type to filter]\n",
+			msg,
+			m.search.View(),
+		))
 	}
 
 	options, start := m.viewableOptions()
@@ -204,11 +208,11 @@ func (m selectModel) View() string {
 			}
 		}
 
-		s += pretty.Sprint(style, option)
-		s += "\n"
+		_, _ = s.WriteString(pretty.Sprint(style, option))
+		_, _ = s.WriteString("\n")
 	}
 
-	return s
+	return s.String()
 }
 
 func (m selectModel) viewableOptions() ([]string, int) {

Original file line number	Diff line number	Diff line change
`@@ -175,21 +175,25 @@ func (m selectModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`func (m selectModel) View() string {`
`178`		`- var s string`
	`178`	`+ var s strings.Builder`
`179`	`179`
`180`	`180`	`msg := pretty.Sprintf(pretty.Bold(), "? %s", m.message)`
`181`	`181`
`182`	`182`	`if m.selected != "" {`
`183`	`183`	`selected := pretty.Sprint(DefaultStyles.Keyword, m.selected)`
`184`		`- s += fmt.Sprintf("%s %s\n", msg, selected)`
	`184`	`+ _, _ = s.WriteString(fmt.Sprintf("%s %s\n", msg, selected))`
`185`	`185`
`186`		`- return s`
	`186`	`+ return s.String()`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`if m.hideSearch {`
`190`		`- s += fmt.Sprintf("%s [Use arrows to move]\n", msg)`
	`190`	`+ _, _ = s.WriteString(fmt.Sprintf("%s [Use arrows to move]\n", msg))`
`191`	`191`	`} else {`
`192`		`- s += fmt.Sprintf("%s %s[Use arrows to move, type to filter]\n", msg, m.search.View())`
	`192`	`+ _, _ = s.WriteString(fmt.Sprintf(`
	`193`	`+ "%s %s[Use arrows to move, type to filter]\n",`
	`194`	`+ msg,`
	`195`	`+ m.search.View(),`
	`196`	`+ ))`
`193`	`197`	`}`
`194`	`198`
`195`	`199`	`options, start := m.viewableOptions()`
`@@ -204,11 +208,11 @@ func (m selectModel) View() string {`
`204`	`208`	`}`
`205`	`209`	`}`
`206`	`210`
`207`		`- s += pretty.Sprint(style, option)`
`208`		`- s += "\n"`
	`211`	`+ _, _ = s.WriteString(pretty.Sprint(style, option))`
	`212`	`+ _, _ = s.WriteString("\n")`
`209`	`213`	`}`
`210`	`214`
`211`		`- return s`
	`215`	`+ return s.String()`
`212`	`216`	`}`
`213`	`217`
`214`	`218`	`func (m selectModel) viewableOptions() ([]string, int) {`