remove unused logger

mafredri · mafredri · commit 6ec33aac13fb · 2025-05-09T09:45:59.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -1129,7 +1129,7 @@ func (a *agent) handleManifest(manifestOK *checkpoint) func(ctx context.Context,
 			)
 			if a.experimentalDevcontainersEnabled {
 				var dcScripts []codersdk.WorkspaceAgentScript
-				scripts, dcScripts = agentcontainers.ExtractAndInitializeDevcontainerScripts(a.logger, manifest.Devcontainers, scripts)
+				scripts, dcScripts = agentcontainers.ExtractAndInitializeDevcontainerScripts(manifest.Devcontainers, scripts)
 				// See ExtractAndInitializeDevcontainerScripts for motivation
 				// behind running dcScripts as post start scripts.
 				scriptRunnerOpts = append(scriptRunnerOpts, agentscripts.WithPostStartScripts(dcScripts...))
diff --git a/agent/agentcontainers/devcontainer.go b/agent/agentcontainers/devcontainer.go
@@ -36,7 +36,6 @@ devcontainer up %s
 // initialize the workspace (e.g. git clone, npm install, etc). This is
 // important if e.g. a Coder module to install @devcontainer/cli is used.
 func ExtractAndInitializeDevcontainerScripts(
-	logger slog.Logger,
 	devcontainers []codersdk.WorkspaceAgentDevcontainer,
 	scripts []codersdk.WorkspaceAgentScript,
 ) (filteredScripts []codersdk.WorkspaceAgentScript, devcontainerScripts []codersdk.WorkspaceAgentScript) {
diff --git a/agent/agentcontainers/devcontainer_test.go b/agent/agentcontainers/devcontainer_test.go
@@ -242,7 +242,6 @@ func TestExtractAndInitializeDevcontainerScripts(t *testing.T) {
 				}
 			}
 			gotFilteredScripts, gotDevcontainerScripts := agentcontainers.ExtractAndInitializeDevcontainerScripts(
-				logger,
 				agentcontainers.ExpandAllDevcontainerPaths(logger, tt.args.expandPath, tt.args.devcontainers),
 				tt.args.scripts,
 			)

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ func (a agent) handleManifest(manifestOK checkpoint) func(ctx context.Context,`
`1129`	`1129`	`)`
`1130`	`1130`	`if a.experimentalDevcontainersEnabled {`
`1131`	`1131`	`var dcScripts []codersdk.WorkspaceAgentScript`
`1132`		`- scripts, dcScripts = agentcontainers.ExtractAndInitializeDevcontainerScripts(a.logger, manifest.Devcontainers, scripts)`
	`1132`	`+ scripts, dcScripts = agentcontainers.ExtractAndInitializeDevcontainerScripts(manifest.Devcontainers, scripts)`
`1133`	`1133`	`// See ExtractAndInitializeDevcontainerScripts for motivation`
`1134`	`1134`	`// behind running dcScripts as post start scripts.`
`1135`	`1135`	`scriptRunnerOpts = append(scriptRunnerOpts, agentscripts.WithPostStartScripts(dcScripts...))`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,6 @@ func TestExtractAndInitializeDevcontainerScripts(t *testing.T) {`
`242`	`242`	`}`
`243`	`243`	`}`
`244`	`244`	`gotFilteredScripts, gotDevcontainerScripts := agentcontainers.ExtractAndInitializeDevcontainerScripts(`
`245`		`- logger,`
`246`	`245`	`agentcontainers.ExpandAllDevcontainerPaths(logger, tt.args.expandPath, tt.args.devcontainers),`
`247`	`246`	`tt.args.scripts,`
`248`	`247`	`)`