Reduce indirection in clibasetest.IO

ammario · ammario · commit 71f2c322025b · 2023-03-09T20:37:50.000Z
diff --git a/cli/clibase/clibasetest/invokation.go b/cli/clibase/clibasetest/invokation.go
@@ -10,22 +10,18 @@ import (
 
 // IO is the standard input, output, and error for a command.
 type IO struct {
-	Stdin  *bytes.Buffer
-	Stdout *bytes.Buffer
-	Stderr *bytes.Buffer
+	Stdin  bytes.Buffer
+	Stdout bytes.Buffer
+	Stderr bytes.Buffer
 }
 
 // FakeIO sets Stdin, Stdout, and Stderr to buffers.
 func FakeIO(i *clibase.Invokation) *IO {
-	b := &IO{
-		Stdin:  bytes.NewBuffer(nil),
-		Stdout: bytes.NewBuffer(nil),
-		Stderr: bytes.NewBuffer(nil),
-	}
-	i.Stdout = b.Stdout
-	i.Stderr = b.Stderr
-	i.Stdin = b.Stdin
-	return b
+	var b IO
+	i.Stdout = &b.Stdout
+	i.Stderr = &b.Stderr
+	i.Stdin = &b.Stdin
+	return &b
 }
 
 type testWriter struct {
