Check indexes in dbmem

code-asher · code-asher · commit 73552bcb9f5b · 2024-02-20T14:09:15.000-09:00
Might have no match, and a -1 will panic.
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -1300,7 +1300,8 @@ func (q *FakeQuerier) DeleteOAuth2ProviderAppTokensByAppAndUserID(_ context.Cont
 		keyIdx := slices.IndexFunc(q.apiKeys, func(key database.APIKey) bool {
 			return key.ID == token.APIKeyID
 		})
-		if q.oauth2ProviderAppSecrets[secretIdx].AppID == arg.AppID && q.apiKeys[keyIdx].UserID == arg.UserID {
+		if secretIdx != -1 && q.oauth2ProviderAppSecrets[secretIdx].AppID == arg.AppID &&
+			keyIdx != -1 && q.apiKeys[keyIdx].UserID == arg.UserID {
 			keyIDsToDelete = append(keyIDsToDelete, token.APIKeyID)
 		} else {
 			tokens = append(tokens, token)
@@ -2370,7 +2371,7 @@ func (q *FakeQuerier) GetOAuth2ProviderAppsByUserID(_ context.Context, userID uu
 						keyIdx := slices.IndexFunc(q.apiKeys, func(key database.APIKey) bool {
 							return key.ID == token.APIKeyID
 						})
-						if q.apiKeys[keyIdx].UserID == userID {
+						if keyIdx != -1 && q.apiKeys[keyIdx].UserID == userID {
 							tokens = append(tokens, token)
 						}
 					}
