fix: cleanup

jaaydenh · jaaydenh · commit 7498908c2f21 · 2025-05-19T21:05:09.000Z
diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -467,7 +467,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					<Slider
 						id={id}
 						className="mt-2"
-						value={[Number.isNaN(Number(value)) ? 0 : Number(value)]}
+						value={[Number.isFinite(Number(value)) ? Number(value) : 0]}
 						onValueChange={([value]) => {
 							onChange(value.toString());
 						}}
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -215,11 +215,18 @@ export const CreateWorkspacePageViewExperimental: FC<
 
 		const currentValues = form.values.rich_parameter_values ?? [];
 
-		const updates = selectedPreset.Parameters.map((presetParameter) => {
+		const updates: Array<{
+			field: string;
+			fieldValue: TypesGen.WorkspaceBuildParameter;
+			parameter: PreviewParameter;
+			presetValue: string;
+		}> = [];
+
+		for (const presetParameter of selectedPreset.Parameters) {
 			const parameterIndex = parameters.findIndex(
 				(p) => p.name === presetParameter.Name,
 			);
-			if (parameterIndex === -1) return null;
+			if (parameterIndex === -1) continue;
 
 			const parameterField = `rich_parameter_values.${parameterIndex}`;
 			const parameter = parameters[parameterIndex];
@@ -228,20 +235,17 @@ export const CreateWorkspacePageViewExperimental: FC<
 			)?.value;
 
 			if (currentValue !== presetParameter.Value) {
-				return {
+				updates.push({
 					field: parameterField,
 					fieldValue: {
 						name: presetParameter.Name,
 						value: presetParameter.Value,
 					},
 					parameter,
 					presetValue: presetParameter.Value,
-				};
+				});
 			}
-			return null;
-		}).filter(
-			(update): update is NonNullable<typeof update> => update !== null,
-		);
+		}
 
 		if (updates.length > 0) {
 			for (const update of updates) {
