fix

mtojek · mtojek · commit 74d9dbe3e37a · 2023-09-12T12:42:48.000+02:00
diff --git a/coderd/workspaceapps/apptest/setup.go b/coderd/workspaceapps/apptest/setup.go
@@ -350,11 +350,13 @@ func createWorkspaceWithApps(t *testing.T, client *codersdk.Client, orgID uuid.U
 	workspaceBuild := coderdtest.AwaitWorkspaceBuildJob(t, client, workspace.LatestBuild.ID)
 
 	// Verify app subdomains
-	for i, app := range workspaceBuild.Resources[0].Agents[0].Apps {
+	for _, app := range workspaceBuild.Resources[0].Agents[0].Apps {
 		require.True(t, app.Subdomain)
 
 		appURL := httpapi.ApplicationURL{
-			AppSlugOrPort: protoApps[i].Slug,
+			// findProtoApp is needed as the order of apps returned from PG database
+			// is not guaranteed.
+			AppSlugOrPort: findProtoApp(t, protoApps, app.Slug).Slug,
 			AgentName:     proxyTestAgentName,
 			WorkspaceName: workspace.Name,
 			Username:      me.Username,
@@ -406,6 +408,16 @@ func createWorkspaceWithApps(t *testing.T, client *codersdk.Client, orgID uuid.U
 	return workspace, agents[0]
 }
 
+func findProtoApp(t *testing.T, protoApps []*proto.App, slug string) proto.App {
+	for _, protoApp := range protoApps {
+		if protoApp.Slug == slug {
+			return *protoApp
+		}
+	}
+	require.FailNowf(t, "proto app not found (slug: %q)", slug)
+	return proto.App{}
+}
+
 func doWithRetries(t require.TestingT, client *codersdk.Client, req *http.Request) (*http.Response, error) {
 	var resp *http.Response
 	var err error
