feat: open app on tab or slim-window

BrunoQuaresma · BrunoQuaresma · commit 774daa1b3ec4 · 2025-01-15T17:14:54.000Z
diff --git a/site/src/modules/resources/AppLink/AppLink.tsx b/site/src/modules/resources/AppLink/AppLink.tsx
@@ -129,12 +129,12 @@ export const AppLink: FC<AppLinkProps> = ({ app, workspace, agent }) => {
 					}
 
 					event.preventDefault();
+
 					// This is an external URI like "vscode://", so
 					// it needs to be opened with the browser protocol handler.
-					if (app.external && !app.url.startsWith("http")) {
-						// If the protocol is external the browser does not
-						// redirect the user from the page.
+					const isBrowserProtocol = app.external && !app.url.startsWith("http");
 
+					if (isBrowserProtocol) {
 						// This is a magic undocumented string that is replaced
 						// with a brand-new session token from the backend.
 						// This only exists for external URLs, and should only
@@ -149,12 +149,22 @@ export const AppLink: FC<AppLinkProps> = ({ app, workspace, agent }) => {
 							setFetchingSessionToken(false);
 						}
 						window.location.href = url;
-					} else {
-						window.open(
-							href,
-							Language.appTitle(appDisplayName, generateRandomString(12)),
-							"width=900,height=600",
-						);
+						return;
+					}
+
+					switch (app.open_in) {
+						case "slim-window": {
+							window.open(
+								href,
+								Language.appTitle(appDisplayName, generateRandomString(12)),
+								"width=900,height=600",
+							);
+							return;
+						}
+						case "tab": {
+							window.open(href);
+							return;
+						}
 					}
 				}}
 			>
