chore: use const instead of magic number

DanielleMaywood · DanielleMaywood · commit 778411028cdc · 2024-09-04T10:18:50.000Z
diff --git a/cli/cliui/select.go b/cli/cliui/select.go
@@ -14,6 +14,8 @@ import (
 	"github.com/coder/serpent"
 )
 
+const defaultSelectModelHeight = 7
+
 type SelectOptions struct {
 	Options []string
 	// Default will be highlighted first if it's a valid option.
@@ -84,7 +86,7 @@ func Select(inv *serpent.Invocation, opts SelectOptions) (string, error) {
 	}
 
 	if initialModel.height == 0 {
-		initialModel.height = 7
+		initialModel.height = defaultSelectModelHeight
 	}
 
 	initialModel.search.Prompt = ""

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ import (`
`14`	`14`	`"github.com/coder/serpent"`
`15`	`15`	`)`
`16`	`16`
	`17`	`+const defaultSelectModelHeight = 7`
	`18`	`+`
`17`	`19`	`type SelectOptions struct {`
`18`	`20`	`Options []string`
`19`	`21`	`// Default will be highlighted first if it's a valid option.`
`@@ -84,7 +86,7 @@ func Select(inv *serpent.Invocation, opts SelectOptions) (string, error) {`
`84`	`86`	`}`
`85`	`87`
`86`	`88`	`if initialModel.height == 0 {`
`87`		`- initialModel.height = 7`
	`89`	`+ initialModel.height = defaultSelectModelHeight`
`88`	`90`	`}`
`89`	`91`
`90`	`92`	`initialModel.search.Prompt = ""`