Skip to content

Commit 78f76e7

Browse files
committed
improve cli tests
1 parent 08adba7 commit 78f76e7

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

cli/stat_test.go

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99

1010
"github.com/stretchr/testify/require"
1111

12+
"github.com/coder/coder/cli/clistat"
1213
"github.com/coder/coder/cli/clitest"
1314
"github.com/coder/coder/testutil"
1415
)
@@ -31,7 +32,7 @@ func TestStatCmd(t *testing.T) {
3132
s := buf.String()
3233
require.NotEmpty(t, s)
3334
// Must be valid JSON
34-
tmp := make([]struct{}, 0)
35+
tmp := make([]clistat.Result, 0)
3536
require.NoError(t, json.NewDecoder(strings.NewReader(s)).Decode(&tmp))
3637
})
3738
t.Run("Table", func(t *testing.T) {
@@ -92,8 +93,12 @@ func TestStatCPUCmd(t *testing.T) {
9293
err := inv.WithContext(ctx).Run()
9394
require.NoError(t, err)
9495
s := buf.String()
95-
tmp := struct{}{}
96+
tmp := clistat.Result{}
9697
require.NoError(t, json.NewDecoder(strings.NewReader(s)).Decode(&tmp))
98+
require.NotZero(t, tmp.Used)
99+
require.NotNil(t, tmp.Total)
100+
require.NotZero(t, *tmp.Total)
101+
require.Equal(t, "cores", tmp.Unit)
97102
})
98103
}
99104

@@ -123,8 +128,12 @@ func TestStatMemCmd(t *testing.T) {
123128
err := inv.WithContext(ctx).Run()
124129
require.NoError(t, err)
125130
s := buf.String()
126-
tmp := struct{}{}
131+
tmp := clistat.Result{}
127132
require.NoError(t, json.NewDecoder(strings.NewReader(s)).Decode(&tmp))
133+
require.NotZero(t, tmp.Used)
134+
require.NotNil(t, tmp.Total)
135+
require.NotZero(t, *tmp.Total)
136+
require.Equal(t, "B", tmp.Unit)
128137
})
129138
}
130139

@@ -154,7 +163,11 @@ func TestStatDiskCmd(t *testing.T) {
154163
err := inv.WithContext(ctx).Run()
155164
require.NoError(t, err)
156165
s := buf.String()
157-
tmp := struct{}{}
166+
tmp := clistat.Result{}
158167
require.NoError(t, json.NewDecoder(strings.NewReader(s)).Decode(&tmp))
168+
require.NotZero(t, tmp.Used)
169+
require.NotNil(t, tmp.Total)
170+
require.NotZero(t, *tmp.Total)
171+
require.Equal(t, "B", tmp.Unit)
159172
})
160173
}

0 commit comments

Comments
 (0)