SQL filter does not generate authz calls

Emyrk · Emyrk · commit 797e7491eacc · 2023-01-26T17:08:11.000-06:00
diff --git a/coderd/authzquery/workspace_test.go b/coderd/authzquery/workspace_test.go
@@ -69,7 +69,7 @@ func TestWorkspaceFunctions(t *testing.T) {
 					require.NoError(t, err)
 				},
 				Asserts: map[string][]rbac.Action{
-					// No rbac checks for this one, uses sql filter
+					// SQL filter does not generate authz calls
 				},
 			},
 		},
diff --git a/coderd/coderdtest/authorize.go b/coderd/coderdtest/authorize.go
@@ -662,7 +662,7 @@ type fakePreparedAuthorizer struct {
 }
 
 func (f *fakePreparedAuthorizer) Authorize(ctx context.Context, object rbac.Object) error {
-	return f.Original.Authorize(ctx, f.Subject, f.Action, object)
+	return f.Original.AuthorizeSQL(ctx, f.Subject, f.Action, object)
 }
 
 // CompileToSQL returns a compiled version of the authorizer that will work for

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,7 @@ type fakePreparedAuthorizer struct {`
`662`	`662`	`}`
`663`	`663`
`664`	`664`	`func (f *fakePreparedAuthorizer) Authorize(ctx context.Context, object rbac.Object) error {`
`665`		`- return f.Original.Authorize(ctx, f.Subject, f.Action, object)`
	`665`	`+ return f.Original.AuthorizeSQL(ctx, f.Subject, f.Action, object)`
`666`	`666`	`}`
`667`	`667`
`668`	`668`	`// CompileToSQL returns a compiled version of the authorizer that will work for`