Return sql.ErrNoRows for GetUsers in databasefake

mafredri · mafredri · commit 7a36610db45f · 2022-05-10T07:29:06.000Z
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -202,7 +202,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams
 
 		// If no users after the time, then we return an empty list.
 		if !found {
-			return []database.User{}, nil
+			return nil, sql.ErrNoRows
 		}
 	}
 
@@ -230,7 +230,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams
 
 	if params.OffsetOpt > 0 {
 		if int(params.OffsetOpt) > len(users)-1 {
-			return []database.User{}, nil
+			return nil, sql.ErrNoRows
 		}
 		users = users[params.OffsetOpt:]
 	}

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams`
`202`	`202`
`203`	`203`	`// If no users after the time, then we return an empty list.`
`204`	`204`	`if !found {`
`205`		`- return []database.User{}, nil`
	`205`	`+ return nil, sql.ErrNoRows`
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`
`@@ -230,7 +230,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams`
`230`	`230`
`231`	`231`	`if params.OffsetOpt > 0 {`
`232`	`232`	`if int(params.OffsetOpt) > len(users)-1 {`
`233`		`- return []database.User{}, nil`
	`233`	`+ return nil, sql.ErrNoRows`
`234`	`234`	`}`
`235`	`235`	`users = users[params.OffsetOpt:]`
`236`	`236`	`}`