pr comments

sreya · sreya · commit 7b49a0d5d54b · 2022-10-18T02:40:49.000Z
diff --git a/coderd/userauth.go b/coderd/userauth.go
@@ -400,7 +400,10 @@ func (api *API) oauthLogin(r *http.Request, params oauthLoginParams) (*http.Cook
 					validUsername bool
 				)
 				for i := 0; i < 10; i++ {
-					params.Username = fmt.Sprintf("%s_%s", original, namesgenerator.GetRandomName(10))
+					alternate := fmt.Sprintf("%s_%s", original, namesgenerator.GetRandomName(1))
+
+					params.Username = httpapi.UsernameFrom(alternate)
+
 					_, err := tx.GetUserByEmailOrUsername(ctx, database.GetUserByEmailOrUsernameParams{
 						Username: params.Username,
 					})
diff --git a/coderd/userauth_test.go b/coderd/userauth_test.go
@@ -449,7 +449,7 @@ func TestUserOIDC(t *testing.T) {
 		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
-			conf := coderdtest.NewFakeOIDCConfig(t, "")
+			conf := coderdtest.NewOIDCConfig(t, "")
 
 			config := conf.OIDCConfig()
 			config.AllowSignups = tc.AllowSignups
@@ -482,7 +482,7 @@ func TestUserOIDC(t *testing.T) {
 	t.Run("AlternateUsername", func(t *testing.T) {
 		t.Parallel()
 
-		conf := coderdtest.NewFakeOIDCConfig(t, "")
+		conf := coderdtest.NewOIDCConfig(t, "")
 
 		config := conf.OIDCConfig()
 		config.AllowSignups = true
