chore: make SelectedOptions private

DanielleMaywood · DanielleMaywood · commit 7cf35d1be364 · 2024-09-04T10:18:46.000Z
diff --git a/cli/cliui/select.go b/cli/cliui/select.go
@@ -281,11 +281,7 @@ func MultiSelect(inv *serpent.Invocation, opts MultiSelectOptions) ([]string, er
 			return values, Canceled
 		}
 
-		for _, option := range m.options {
-			if option.chosen {
-				values = append(values, option.option)
-			}
-		}
+		values = m.selectedOptions()
 	}
 	return values, err
 }
@@ -393,15 +389,15 @@ func (m multiSelectModel) View() string {
 			s += fmt.Sprintf("%s%s %s\n", cursor, chosen, o)
 		}
 	} else {
-		selected := pretty.Sprint(DefaultStyles.Keyword, strings.Join(m.SelectedOptions(), ", "))
+		selected := pretty.Sprint(DefaultStyles.Keyword, strings.Join(m.selectedOptions(), ", "))
 
 		s += fmt.Sprintf("%s %s\n", msg, selected)
 	}
 
 	return s
 }
 
-func (m multiSelectModel) SelectedOptions() []string {
+func (m multiSelectModel) selectedOptions() []string {
 	selected := []string{}
 	for _, o := range m.options {
 		if o.chosen {

Original file line number	Diff line number	Diff line change
`@@ -281,11 +281,7 @@ func MultiSelect(inv *serpent.Invocation, opts MultiSelectOptions) ([]string, er`
`281`	`281`	`return values, Canceled`
`282`	`282`	`}`
`283`	`283`
`284`		`- for _, option := range m.options {`
`285`		`- if option.chosen {`
`286`		`- values = append(values, option.option)`
`287`		`- }`
`288`		`- }`
	`284`	`+ values = m.selectedOptions()`
`289`	`285`	`}`
`290`	`286`	`return values, err`
`291`	`287`	`}`
`@@ -393,15 +389,15 @@ func (m multiSelectModel) View() string {`
`393`	`389`	`s += fmt.Sprintf("%s%s %s\n", cursor, chosen, o)`
`394`	`390`	`}`
`395`	`391`	`} else {`
`396`		`- selected := pretty.Sprint(DefaultStyles.Keyword, strings.Join(m.SelectedOptions(), ", "))`
	`392`	`+ selected := pretty.Sprint(DefaultStyles.Keyword, strings.Join(m.selectedOptions(), ", "))`
`397`	`393`
`398`	`394`	`s += fmt.Sprintf("%s %s\n", msg, selected)`
`399`	`395`	`}`
`400`	`396`
`401`	`397`	`return s`
`402`	`398`	`}`
`403`	`399`
`404`		`-func (m multiSelectModel) SelectedOptions() []string {`
	`400`	`+func (m multiSelectModel) selectedOptions() []string {`
`405`	`401`	`selected := []string{}`
`406`	`402`	`for _, o := range m.options {`
`407`	`403`	`if o.chosen {`