fix: rewrite urls with multiple slashes

mtojek · mtojek · commit 7d598e4935ac · 2025-02-11T15:57:32.000+01:00
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -788,6 +788,7 @@ func New(options *Options) *API {
 		httpmw.AttachRequestID,
 		httpmw.ExtractRealIP(api.RealIPConfig),
 		httpmw.Logger(api.Logger),
+		stripSlashesMW,
 		rolestore.CustomRoleMW,
 		prometheusMW,
 		// Build-Version is helpful for debugging.
@@ -1731,3 +1732,34 @@ func ReadExperiments(log slog.Logger, raw []string) codersdk.Experiments {
 	}
 	return exps
 }
+
+var multipleSlashesRe = regexp.MustCompile(`/+`)
+
+func stripSlashesMW(next http.Handler) http.Handler {
+	fn := func(w http.ResponseWriter, r *http.Request) {
+		var path string
+		rctx := chi.RouteContext(r.Context())
+		if rctx != nil && rctx.RoutePath != "" {
+			path = rctx.RoutePath
+		} else {
+			path = r.URL.Path
+		}
+
+		// Normalize multiple slashes to a single slash
+		newPath := multipleSlashesRe.ReplaceAllString(path, "/")
+
+		// Ensure it doesn't strip the root `/`
+		if len(newPath) > 1 && newPath[len(newPath)-1] == '/' {
+			newPath = strings.TrimSuffix(newPath, "/")
+		}
+
+		// Apply the cleaned path
+		if rctx != nil {
+			rctx.RoutePath = newPath
+		}
+		r.URL.Path = newPath
+
+		next.ServeHTTP(w, r)
+	}
+	return http.HandlerFunc(fn)
+}
diff --git a/site/vite.config.mts b/site/vite.config.mts
@@ -52,6 +52,12 @@ export default defineConfig({
 				"csrf_token=JXm9hOUdZctWt0ZZGAy9xiS/gxMKYOThdxjjMnMUyn4=; Path=/; HttpOnly; SameSite=Lax",
 		},
 		proxy: {
+			"//": {
+				changeOrigin: true,
+				target: process.env.CODER_HOST || "http://localhost:3000",
+				secure: process.env.NODE_ENV === "production",
+				rewrite: (path) => path.replace(/\/+/g, "/"),
+			},
 			"/api": {
 				ws: true,
 				changeOrigin: true,
