Remove redundant existence checks

code-asher · code-asher · commit 7e2db8863f85 · 2023-12-14T10:48:57.000-09:00
Also remove a ? since that condition would short-circuit if `secrets`
was not set.  We could just do a falsey check, but I like to compare
length to a number.
diff --git a/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/EditOAuth2AppPageView.tsx b/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/EditOAuth2AppPageView.tsx
@@ -225,7 +225,7 @@ const OAuth2AppSecretsTable: FC<OAuth2AppSecretsTableProps> = ({
           </TableHead>
           <TableBody>
             {isLoadingSecrets && <TableLoader />}
-            {!isLoadingSecrets && (!secrets || secrets?.length === 0) && (
+            {!isLoadingSecrets && (!secrets || secrets.length === 0) && (
               <TableRow>
                 <TableCell colSpan={999}>
                   <div css={{ textAlign: "center" }}>
@@ -235,8 +235,6 @@ const OAuth2AppSecretsTable: FC<OAuth2AppSecretsTableProps> = ({
               </TableRow>
             )}
             {!isLoadingSecrets &&
-              secrets &&
-              secrets?.length > 0 &&
               secrets?.map((secret) => (
                 <OAuth2SecretRow
                   key={secret.id}
