Add TODO

Emyrk · Emyrk · commit 7e4ed878a23c · 2023-04-13T09:43:32.000-05:00
diff --git a/coderd/database/dbgen/generator.go b/coderd/database/dbgen/generator.go
@@ -354,7 +354,7 @@ func WorkspaceProxy(t testing.TB, db database.Store, orig database.WorkspaceProx
 		CreatedAt:         takeFirst(orig.CreatedAt, database.Now()),
 		UpdatedAt:         takeFirst(orig.UpdatedAt, database.Now()),
 	})
-	require.NoError(t, err, "insert app")
+	require.NoError(t, err, "insert proxy")
 	return secret, resource
 }
 
diff --git a/coderd/workspaceapps/db.go b/coderd/workspaceapps/db.go
@@ -154,6 +154,11 @@ func (p *DBTokenProvider) IssueToken(ctx context.Context, rw http.ResponseWriter
 		// Otherwise, we need to redirect to the app auth endpoint, which will
 		// redirect back to the app (with an encrypted API key) after the user
 		// has logged in.
+		//
+		// TODO: We should just make this a "BrowserURL" field on the issue struct. Then
+		// we can remove this logic and just defer to that. It can be set closer to the
+		// actual initial request that makes the IssueTokenRequest. Eg the external moon.
+		// This would replace RawQuery and AppPath fields.
 		redirectURI := *appBaseURL
 		if dbReq.AppURL != nil {
 			// Just use the user's current path and query if set.
diff --git a/coderd/workspaceapps/provider.go b/coderd/workspaceapps/provider.go
@@ -29,6 +29,8 @@ type ResolveRequestOpts struct {
 	AppHostname    string
 
 	AppRequest Request
+	// TODO: Replace these 2 fields with a "BrowserURL" field which is used for
+	// redirecting the user back to their initial request after authenticating.
 	// AppPath is the path under the app that was hit.
 	AppPath string
 	// AppQuery is the raw query of the request.

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ func WorkspaceProxy(t testing.TB, db database.Store, orig database.WorkspaceProx`
`354`	`354`	`CreatedAt: takeFirst(orig.CreatedAt, database.Now()),`
`355`	`355`	`UpdatedAt: takeFirst(orig.UpdatedAt, database.Now()),`
`356`	`356`	`})`
`357`		`- require.NoError(t, err, "insert app")`
	`357`	`+ require.NoError(t, err, "insert proxy")`
`358`	`358`	`return secret, resource`
`359`	`359`	`}`
`360`	`360`