Fix tests

BrunoQuaresma · BrunoQuaresma · commit 7e97461beca1 · 2022-10-24T21:03:06.000Z
diff --git a/site/src/components/BuildsTable/BuildRow.tsx b/site/src/components/BuildsTable/BuildRow.tsx
@@ -23,7 +23,6 @@ export const BuildRow: React.FC<BuildRowProps> = ({ build }) => {
   return (
     <TableRow
       hover
-      key={build.id}
       data-testid={`build-${build.id}`}
       className={styles.buildRow}
     >
diff --git a/site/src/components/BuildsTable/BuildsTable.tsx b/site/src/components/BuildsTable/BuildsTable.tsx
@@ -4,7 +4,7 @@ import TableBody from "@material-ui/core/TableBody"
 import TableCell from "@material-ui/core/TableCell"
 import TableContainer from "@material-ui/core/TableContainer"
 import TableRow from "@material-ui/core/TableRow"
-import { FC } from "react"
+import { FC, Fragment } from "react"
 import * as TypesGen from "../../api/typesGenerated"
 import { EmptyState } from "../EmptyState/EmptyState"
 import { TableLoader } from "../TableLoader/TableLoader"
@@ -64,12 +64,12 @@ export const BuildsTable: FC<React.PropsWithChildren<BuildsTableProps>> = ({
               const builds = buildsByDate[dateStr]
 
               return (
-                <>
+                <Fragment key={dateStr}>
                   <BuildDateRow date={new Date(dateStr)} />
                   {builds.map((build) => (
                     <BuildRow key={build.id} build={build} />
                   ))}
-                </>
+                </Fragment>
               )
             })}
 
diff --git a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx
@@ -288,7 +288,8 @@ describe("WorkspacePage", () => {
       // Wait for the results to be loaded
       await waitFor(async () => {
         const rows = table.querySelectorAll("tbody > tr")
-        expect(rows).toHaveLength(MockBuilds.length)
+        // Added +1 because of the date row
+        expect(rows).toHaveLength(MockBuilds.length + 1)
       })
     })
   })

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ export const BuildRow: React.FC<BuildRowProps> = ({ build }) => {`
`23`	`23`	`return (`
`24`	`24`	`<TableRow`
`25`	`25`	`hover`
`26`		`- key={build.id}`
`27`	`26`	data-testid={`build-${build.id}`}
`28`	`27`	`className={styles.buildRow}`
`29`	`28`	`>`