Add zero state to site

ammario · ammario · commit 7e9e5ef1df24 · 2022-08-31T02:55:40.000Z
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/agentstats.sql b/coderd/database/queries/agentstats.sql
@@ -13,12 +13,10 @@ VALUES
 
 -- name: GetDAUsFromAgentStats :many
 select
-	created_at::date as date,
+	(created_at at TIME ZONE 'UTC')::date as date,
 	count(distinct(user_id)) as daus
 from
 	agent_stats
-where
-	cast(payload->>'num_comms' as integer) > 0
 group by
 	date
 order by
diff --git a/coderd/metricscache/cache.go b/coderd/metricscache/cache.go
@@ -22,8 +22,10 @@ type Cache struct {
 
 	getDAUsResponse atomic.Pointer[codersdk.GetDAUsResponse]
 
-	wg     sync.WaitGroup
-	doneCh chan struct{}
+	wg sync.WaitGroup
+
+	closeOnce sync.Once
+	doneCh    chan struct{}
 }
 
 func New(db database.Store, log slog.Logger) *Cache {
@@ -141,7 +143,9 @@ func (c *Cache) Start(
 }
 
 func (c *Cache) Close() error {
-	close(c.doneCh)
+	c.closeOnce.Do(func() {
+		close(c.doneCh)
+	})
 	c.wg.Wait()
 	return nil
 }
diff --git a/coderd/metricscache/cache_test.go b/coderd/metricscache/cache_test.go
@@ -24,6 +24,35 @@ func Test_fillEmptyDAUDays(t *testing.T) {
 		want []database.GetDAUsFromAgentStatsRow
 	}{
 		{"empty", args{}, nil},
+		{"one hole", args{
+			rows: []database.GetDAUsFromAgentStatsRow{
+				{
+					Date: date(2022, 8, 27),
+					Daus: 1,
+				},
+				{
+					Date: date(2022, 8, 30),
+					Daus: 1,
+				},
+			},
+		}, []database.GetDAUsFromAgentStatsRow{
+			{
+				Date: date(2022, 8, 27),
+				Daus: 1,
+			},
+			{
+				Date: date(2022, 8, 28),
+				Daus: 0,
+			},
+			{
+				Date: date(2022, 8, 29),
+				Daus: 0,
+			},
+			{
+				Date: date(2022, 8, 30),
+				Daus: 1,
+			},
+		}},
 		{"no holes", args{
 			rows: []database.GetDAUsFromAgentStatsRow{
 				{
diff --git a/site/src/pages/UsersPage/DAUChart.tsx b/site/src/pages/UsersPage/DAUChart.tsx
@@ -31,10 +31,15 @@ import { HelpTooltip, HelpTooltipText, HelpTooltipTitle } from "components/Toolt
 ChartJS.register(CategoryScale, LinearScale, PointElement, LineElement, Title, Tooltip, Legend)
 
 export const DAUChart: FC<DAUChartProps> = ({ userMetricsData }) => {
+  const theme: Theme = useTheme()
+
   if (userMetricsData.entries.length === 0) {
-    return <p>DAU stats are loading. Check back later.</p>
+    return (
+      <div style={{ marginTop: "-20px" }}>
+        <p>DAU stats are loading. Check back later.</p>
+      </div>
+    )
   }
-  const theme: Theme = useTheme()
 
   const labels = userMetricsData.entries.map((val) => {
     return moment(val.date).format("l")

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,10 @@ type Cache struct {`
`22`	`22`
`23`	`23`	`getDAUsResponse atomic.Pointer[codersdk.GetDAUsResponse]`
`24`	`24`
`25`		`- wg sync.WaitGroup`
`26`		`- doneCh chan struct{}`
	`25`	`+ wg sync.WaitGroup`
	`26`	`+`
	`27`	`+ closeOnce sync.Once`
	`28`	`+ doneCh chan struct{}`
`27`	`29`	`}`
`28`	`30`
`29`	`31`	`func New(db database.Store, log slog.Logger) *Cache {`
`@@ -141,7 +143,9 @@ func (c *Cache) Start(`
`141`	`143`	`}`
`142`	`144`
`143`	`145`	`func (c *Cache) Close() error {`
`144`		`- close(c.doneCh)`
	`146`	`+ c.closeOnce.Do(func() {`
	`147`	`+ close(c.doneCh)`
	`148`	`+ })`
`145`	`149`	`c.wg.Wait()`
`146`	`150`	`return nil`
`147`	`151`	`}`