refactored fields extension on the logger

ibetitsmike · ibetitsmike · commit 7edb8c378729 · 2025-04-07T09:45:46.000Z
diff --git a/coderd/httpmw/logger.go b/coderd/httpmw/logger.go
@@ -36,7 +36,6 @@ func Logger(log slog.Logger) func(next http.Handler) http.Handler {
 			)
 
 			logContext := &RequestLoggerContext{
-				Fields:  map[string]any{},
 				log:     &httplog,
 				written: false,
 			}
@@ -87,21 +86,20 @@ func Logger(log slog.Logger) func(next http.Handler) http.Handler {
 }
 
 type RequestLoggerContext struct {
-	Fields map[string]any
-
 	log     *slog.Logger
 	written bool
 }
 
+func (c *RequestLoggerContext) WithFields(fields ...slog.Field) {
+	newLogger := c.log.With(fields...)
+	c.log = &newLogger
+}
+
 func (c *RequestLoggerContext) WriteLog(ctx context.Context, msg string, status int) {
 	if c.written {
 		return
 	}
 	c.written = true
-	// append extra fields to the logger
-	for k, v := range c.Fields {
-		c.log.With(slog.F(k, v))
-	}
 
 	if status >= http.StatusInternalServerError {
 		c.log.Error(ctx, msg)
