fix(provisioner/terraform/tfparse): skip evaluation of defaults if no workspace_tags found

johnstcn · johnstcn · commit 7eff859b4de6 · 2025-01-03T10:34:59.000Z
diff --git a/coderd/templateversions_test.go b/coderd/templateversions_test.go
@@ -460,6 +460,20 @@ func TestPostTemplateVersionsByOrganization(t *testing.T) {
 				},
 				wantTags: map[string]string{"owner": templateAdminUser.ID.String(), "scope": "user"},
 			},
+			// Ref: https://github.com/coder/coder/issues/16021
+			{
+				name: "main.tf with no workspace_tags and a function call in a parameter default",
+				files: map[string]string{
+					`main.tf`: `
+						data "coder_parameter" "foo" {
+						name         = "foo"
+						type         = "list(string)"
+						default      = jsonencode(["1", "2", "3", "4"])
+						mutable      = true
+					}`,
+				},
+				wantTags: map[string]string{"owner": "", "scope": "organization"},
+			},
 		} {
 			tt := tt
 			t.Run(tt.name, func(t *testing.T) {
diff --git a/provisioner/terraform/tfparse/tfparse.go b/provisioner/terraform/tfparse/tfparse.go
@@ -80,7 +80,7 @@ func New(workdir string, opts ...Option) (*Parser, tfconfig.Diagnostics) {
 }
 
 // WorkspaceTags looks for all coder_workspace_tags datasource in the module
-// and returns the raw values for the tags. Use
+// and returns the raw values for the tags.
 func (p *Parser) WorkspaceTags(ctx context.Context) (map[string]string, error) {
 	tags := map[string]string{}
 	var skipped []string
@@ -166,6 +166,11 @@ func (p *Parser) WorkspaceTagDefaults(ctx context.Context) (map[string]string, e
 		return nil, xerrors.Errorf("extract workspace tags: %w", err)
 	}
 
+	if len(tags) == 0 {
+		//nolint: nilnil
+		return nil, nil
+	}
+
 	// To evaluate the expressions, we need to load the default values for
 	// variables and parameters.
 	varsDefaults, err := p.VariableDefaults(ctx)
