Add titles

BrunoQuaresma · BrunoQuaresma · commit 7f139d73b82a · 2023-03-22T16:27:34.000Z
diff --git a/site/src/i18n/en/templateSettingsPage.json b/site/src/i18n/en/templateSettingsPage.json
@@ -1,5 +1,5 @@
 {
-  "title": "Template settings",
+  "title": "General Settings",
   "nameLabel": "Name",
   "displayNameLabel": "Display name",
   "descriptionLabel": "Description",
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
@@ -35,7 +35,7 @@ export const TemplateSettingsPage: FC = () => {
   return (
     <>
       <Helmet>
-        <title>{pageTitle(t("title"))}</title>
+        <title>{pageTitle([template.name, t("title")])}</title>
       </Helmet>
       <TemplateSettingsPageView
         canSetMaxTTL={canSetMaxTTL}
diff --git a/site/src/pages/TemplateSettingsPage/TemplatePermissionsPage/TemplatePermissionsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplatePermissionsPage/TemplatePermissionsPage.tsx
@@ -28,7 +28,7 @@ export const TemplatePermissionsPage: FC<
   return (
     <>
       <Helmet>
-        <title>{pageTitle(`${template?.name} · Permissions`)}</title>
+        <title>{pageTitle([template.name, "Permissions"])}</title>
       </Helmet>
       <ChooseOne>
         <Cond condition={!isTemplateRBACEnabled}>
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.tsx b/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.tsx
@@ -5,15 +5,13 @@ import { useDashboard } from "components/Dashboard/DashboardProvider"
 import { displaySuccess } from "components/GlobalSnackbar/utils"
 import { FC } from "react"
 import { Helmet } from "react-helmet-async"
-import { useTranslation } from "react-i18next"
 import { useNavigate, useParams } from "react-router-dom"
 import { pageTitle } from "util/page"
 import { useTemplateSettingsContext } from "../TemplateSettingsLayout"
 import { TemplateSchedulePageView } from "./TemplateSchedulePageView"
 
 const TemplateSchedulePage: FC = () => {
   const { template: templateName } = useParams() as { template: string }
-  const { t } = useTranslation("templateSettingsPage")
   const navigate = useNavigate()
   const { template } = useTemplateSettingsContext()
   const { entitlements } = useDashboard()
@@ -35,7 +33,7 @@ const TemplateSchedulePage: FC = () => {
   return (
     <>
       <Helmet>
-        <title>{pageTitle(t("title"))}</title>
+        <title>{pageTitle([template.name, "Schedule"])}</title>
       </Helmet>
       <TemplateSchedulePageView
         canSetMaxTTL={canSetMaxTTL}
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSettingsLayout.tsx b/site/src/pages/TemplateSettingsPage/TemplateSettingsLayout.tsx
@@ -65,7 +65,7 @@ export const TemplateSettingsLayout: FC = () => {
   return (
     <>
       <Helmet>
-        <title>{pageTitle("Settings")}</title>
+        <title>{pageTitle([templateName, "Settings"])}</title>
       </Helmet>
 
       {settings ? (
diff --git a/site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesPage.tsx
@@ -46,7 +46,7 @@ export const TemplateVariablesPage: FC = () => {
   return (
     <>
       <Helmet>
-        <title>{pageTitle(t("title"))}</title>
+        <title>{pageTitle([template.name, t("title")])}</title>
       </Helmet>
 
       <TemplateVariablesPageView
diff --git a/site/src/util/page.ts b/site/src/util/page.ts
@@ -1,3 +1,4 @@
-export const pageTitle = (prefix: string): string => {
-  return `${prefix} – Coder`
+export const pageTitle = (prefix: string | string[]): string => {
+  const title = Array.isArray(prefix) ? prefix.join(" · ") : prefix
+  return `${title} - Coder`
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "title": "Template settings",`
	`2`	`+ "title": "General Settings",`
`3`	`3`	`"nameLabel": "Name",`
`4`	`4`	`"displayNameLabel": "Display name",`
`5`	`5`	`"descriptionLabel": "Description",`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
`1`		`-export const pageTitle = (prefix: string): string => {`
`2`		- return `${prefix} – Coder`
	`1`	`+export const pageTitle = (prefix: string \| string[]): string => {`
	`2`	`+ const title = Array.isArray(prefix) ? prefix.join(" · ") : prefix`
	`3`	+ return `${title} - Coder`
`3`	`4`	`}`