fix: use asChild prop instead of as prop for Button components

blink-so[bot] · jaaydenh · blink-so[bot] · commit 7f56518ec61d · 2025-06-17T16:13:37.000Z
- Fix TypeScript errors in EphemeralParametersDialog and BuildParametersPopover
- Use correct Button component pattern with asChild and Link

Co-authored-by: jaaydenh &lt;1858163+jaaydenh@users.noreply.github.com&gt;
diff --git a/site/src/components/EphemeralParametersDialog/EphemeralParametersDialog.tsx b/site/src/components/EphemeralParametersDialog/EphemeralParametersDialog.tsx
@@ -40,8 +40,8 @@ export const EphemeralParametersDialog: FC<EphemeralParametersDialogProps> = ({
 			</div>
 			<p>You can continue without setting values for these parameters, or go to the workspace parameters page to configure them.</p>
 			<div style={{ marginTop: "16px" }}>
-				<Button as={Link} to={parametersPageUrl} onClick={onClose}>
-					Go to Parameters Page
+				<Button asChild onClick={onClose}>
+					<Link to={parametersPageUrl}>Go to Parameters Page</Link>
 				</Button>
 			</div>
 		</>
diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
@@ -129,12 +129,11 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({
 				</div>
 				
 				<Button
-					as={Link}
-					to={parametersPageUrl}
+					asChild
 					css={{ width: "100%" }}
 					onClick={() => popover.setOpen(false)}
 				>
-					Go to Parameters Page
+					<Link to={parametersPageUrl}>Go to Parameters Page</Link>
 				</Button>
 			</div>
 		);
