linting

Emyrk · Emyrk · commit 7ff0bb0d455c · 2024-09-16T15:58:50.000-05:00
diff --git a/coderd/members.go b/coderd/members.go
@@ -217,7 +217,7 @@ func (api *API) putMemberRoles(rw http.ResponseWriter, r *http.Request) {
 	defer commitAudit()
 
 	// Check if changing roles is allowed
-	if !api.allowChangingMemberRoles(rw, ctx, member, organization) {
+	if !api.allowChangingMemberRoles(ctx, rw, member, organization) {
 		return
 	}
 
@@ -265,7 +265,7 @@ func (api *API) putMemberRoles(rw http.ResponseWriter, r *http.Request) {
 	httpapi.Write(ctx, rw, http.StatusOK, resp[0])
 }
 
-func (api *API) allowChangingMemberRoles(rw http.ResponseWriter, ctx context.Context, member httpmw.OrganizationMember, organization database.Organization) bool {
+func (api *API) allowChangingMemberRoles(ctx context.Context, rw http.ResponseWriter, member httpmw.OrganizationMember, organization database.Organization) bool {
 	// nolint:gocritic // The caller could be an org admin without this perm.
 	// We need to disable manual role assignment if role sync is enabled for
 	// the given organization.

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ func (api API) putMemberRoles(rw http.ResponseWriter, r http.Request) {`
`217`	`217`	`defer commitAudit()`
`218`	`218`
`219`	`219`	`// Check if changing roles is allowed`
`220`		`- if !api.allowChangingMemberRoles(rw, ctx, member, organization) {`
	`220`	`+ if !api.allowChangingMemberRoles(ctx, rw, member, organization) {`
`221`	`221`	`return`
`222`	`222`	`}`
`223`	`223`
`@@ -265,7 +265,7 @@ func (api API) putMemberRoles(rw http.ResponseWriter, r http.Request) {`
`265`	`265`	`httpapi.Write(ctx, rw, http.StatusOK, resp[0])`
`266`	`266`	`}`
`267`	`267`
`268`		`-func (api *API) allowChangingMemberRoles(rw http.ResponseWriter, ctx context.Context, member httpmw.OrganizationMember, organization database.Organization) bool {`
	`268`	`+func (api *API) allowChangingMemberRoles(ctx context.Context, rw http.ResponseWriter, member httpmw.OrganizationMember, organization database.Organization) bool {`
`269`	`269`	`// nolint:gocritic // The caller could be an org admin without this perm.`
`270`	`270`	`// We need to disable manual role assignment if role sync is enabled for`
`271`	`271`	`// the given organization.`