Fix hanging tests

code-asher · code-asher · commit 80416094a624 · 2023-10-19T10:02:53.000-08:00
I am not really sure what ws.connected is doing but it seems to somehow
block updates.  Something to do with `act()` maybe?

Basically, the useEffect creating the terminal never updates once the
config query finishes, so the web socket is never created, and the test
hangs forever.

It might have been working before only because the web socket was
created using xstate rather than useEffect and once it connected it
would unblock and React could update again but this is just a guess.
diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx
@@ -127,7 +127,7 @@ describe("TerminalPage", () => {
     const { container } = await renderTerminal();
 
     // Then
-    await ws.connected;
+    await ws.nextMessage;
     ws.send(text);
     await expectTerminalText(container, text);
     ws.close();
@@ -143,7 +143,6 @@ describe("TerminalPage", () => {
     await renderTerminal();
 
     // Then
-    await ws.connected;
     const msg = await ws.nextMessage;
     const req = JSON.parse(new TextDecoder().decode(msg as Uint8Array));
     expect(req.height).toBeGreaterThan(0);
@@ -164,7 +163,7 @@ describe("TerminalPage", () => {
     );
 
     // Then
-    await ws.connected;
+    await ws.nextMessage;
     ws.send(text);
     await expectTerminalText(container, text);
     ws.close();
