🧹

aslilac · aslilac · commit 8064232f13c5 · 2024-07-02T16:58:56.000Z
diff --git a/site/src/modules/resources/AppLink/AppLink.tsx b/site/src/modules/resources/AppLink/AppLink.tsx
@@ -3,7 +3,7 @@ import ErrorOutlineIcon from "@mui/icons-material/ErrorOutline";
 import CircularProgress from "@mui/material/CircularProgress";
 import Link from "@mui/material/Link";
 import Tooltip from "@mui/material/Tooltip";
-import { type FC, useState } from "react";
+import { type FC, type MouseEvent, useState } from "react";
 import { API } from "api/api";
 import type * as TypesGen from "api/typesGenerated";
 import { useProxy } from "contexts/ProxyContext";
@@ -119,12 +119,11 @@ export const AppLink: FC<AppLinkProps> = ({ app, workspace, agent }) => {
         endIcon={isPrivateApp ? undefined : <ShareIcon app={app} />}
         disabled={!canClick}
         href={href}
-        target="_blank"
         css={{
           pointerEvents: canClick ? undefined : "none",
           textDecoration: "none !important",
         }}
-        onClick={async (event) => {
+        onClick={async (event: MouseEvent<HTMLElement>) => {
           if (!canClick) {
             return;
           }
diff --git a/site/src/modules/resources/TerminalLink/TerminalLink.tsx b/site/src/modules/resources/TerminalLink/TerminalLink.tsx
@@ -1,5 +1,5 @@
 import Link from "@mui/material/Link";
-import type { FC } from "react";
+import type { FC, MouseEvent } from "react";
 import type * as TypesGen from "api/typesGenerated";
 import { TerminalIcon } from "components/Icons/TerminalIcon";
 import { generateRandomString } from "utils/random";
@@ -40,8 +40,7 @@ export const TerminalLink: FC<TerminalLinkProps> = ({
       component={AgentButton}
       startIcon={<TerminalIcon />}
       href={href}
-      target="_blank"
-      onClick={(event) => {
+      onClick={(event: MouseEvent<HTMLElement>) => {
         event.preventDefault();
         window.open(
           href,
