fix(site): don't mark metadata with interval: 0 as stale (#8627)

coadler · web-flow · commit 830020df155e · 2023-07-20T15:05:32.000-05:00
diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
@@ -31,7 +31,10 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {
     if (year <= 1970 || isNaN(year)) {
       return "loading"
     }
-    if (item.result.age > staleThreshold) {
+    // There is a special circumstance for metadata with `interval: 0`. It is
+    // expected that they run once and never again, so never display them as
+    // stale.
+    if (item.result.age > staleThreshold && item.description.interval > 0) {
       return "stale"
     }
     return "valid"

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,10 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {`
`31`	`31`	`if (year <= 1970 \|\| isNaN(year)) {`
`32`	`32`	`return "loading"`
`33`	`33`	`}`
`34`		`- if (item.result.age > staleThreshold) {`
	`34`	+ // There is a special circumstance for metadata with `interval: 0`. It is
	`35`	`+ // expected that they run once and never again, so never display them as`
	`36`	`+ // stale.`
	`37`	`+ if (item.result.age > staleThreshold && item.description.interval > 0) {`
`35`	`38`	`return "stale"`
`36`	`39`	`}`
`37`	`40`	`return "valid"`