Revert "Move CloseStdin into clibase"

ammario · ammario · commit 8471555cbee5 · 2023-06-10T16:55:37.000Z
This reverts commit 65cdbcc.
diff --git a/cli/clibase/cmd.go b/cli/clibase/cmd.go
@@ -381,16 +381,6 @@ func (inv *Invocation) run(state *runState) error {
 	return nil
 }
 
-// CloseStdin closes the invocation's Stdin if it is an io.Closer.
-func (inv *Invocation) CloseStdin() error {
-	// If we don't close Stdin, the io.Copy below may
-	// block indefinitely on Stdin Read.
-	if rc, ok := inv.Stdin.(io.Closer); ok {
-		return rc.Close()
-	}
-	return nil
-}
-
 type RunCommandError struct {
 	Cmd *Cmd
 	Err error
diff --git a/cli/ssh.go b/cli/ssh.go
@@ -219,7 +219,9 @@ func (r *RootCmd) ssh() *clibase.Cmd {
 						rawSSH.Close()
 						// If we don't close Stdin, the io.Copy below may
 						// block indefinitely on Stdin Read.
-						_ = inv.CloseStdin()
+						if rc, ok := inv.Stdin.(io.Closer); ok {
+							rc.Close()
+						}
 						return nil
 					}, logger, client, workspace)
 				}()
