Refactor Alert

BrunoQuaresma · BrunoQuaresma · commit 8499bcbf8633 · 2023-09-06T19:06:47.000Z
diff --git a/site/src/components/Alert/Alert.stories.tsx b/site/src/components/Alert/Alert.stories.tsx
@@ -1,6 +1,5 @@
 import { Alert } from "./Alert";
 import Button from "@mui/material/Button";
-import Link from "@mui/material/Link";
 import type { Meta, StoryObj } from "@storybook/react";
 
 const meta: Meta<typeof Alert> = {
@@ -21,7 +20,6 @@ export const Success: Story = {
   args: {
     children: "You're doing great!",
     severity: "success",
-    onRetry: undefined,
   },
 };
 
@@ -56,14 +54,3 @@ export const WarningWithActionAndDismiss: Story = {
     severity: "warning",
   },
 };
-
-export const WithChildren: Story = {
-  args: {
-    severity: "warning",
-    children: (
-      <div>
-        This is a message with a <Link href="#">link</Link>
-      </div>
-    ),
-  },
-};
diff --git a/site/src/components/Alert/Alert.tsx b/site/src/components/Alert/Alert.tsx
@@ -8,14 +8,12 @@ import Box from "@mui/material/Box";
 export type AlertProps = MuiAlertProps & {
   actions?: ReactNode;
   dismissible?: boolean;
-  onRetry?: () => void;
   onDismiss?: () => void;
 };
 
 export const Alert: FC<AlertProps> = ({
   children,
   actions,
-  onRetry,
   dismissible,
   severity,
   onDismiss,
@@ -34,13 +32,6 @@ export const Alert: FC<AlertProps> = ({
             {/* CTAs passed in by the consumer */}
             {actions}
 
-            {/* retry CTA */}
-            {onRetry && (
-              <Button variant="text" size="small" onClick={onRetry}>
-                Retry
-              </Button>
-            )}
-
             {/* close CTA */}
             {dismissible && (
               <Button
diff --git a/site/src/components/Alert/ErrorAlert.stories.tsx b/site/src/components/Alert/ErrorAlert.stories.tsx
@@ -1,7 +1,6 @@
 import Button from "@mui/material/Button";
 import { mockApiError } from "testHelpers/entities";
 import type { Meta, StoryObj } from "@storybook/react";
-import { action } from "@storybook/addon-actions";
 import { ErrorAlert } from "./ErrorAlert";
 
 const mockError = mockApiError({
@@ -15,7 +14,6 @@ const meta: Meta<typeof ErrorAlert> = {
   args: {
     error: mockError,
     dismissible: false,
-    onRetry: undefined,
   },
 };
 
@@ -57,15 +55,6 @@ export const WithActionAndDismiss: Story = {
 
 export const WithRetry: Story = {
   args: {
-    onRetry: action("retry"),
-    dismissible: true,
-  },
-};
-
-export const WithActionRetryAndDismiss: Story = {
-  args: {
-    actions: [ExampleAction],
-    onRetry: action("retry"),
     dismissible: true,
   },
 };
